search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

Create python package #79

Closed offlinehacker closed 10 years ago

offlinehacker commented 10 years ago

I understand that you don't want to depend on external packages, but on the other hand on some distros it would be much easier to package and deploy graph-explorer if python package would be made.

For start simple setup.py file would be nice ;)

Dieterbe commented 10 years ago

Sure. GE should be more packaging friendly. I just prioritize my time on core features for now. Any help would be appreciated!

offlinehacker commented 10 years ago

So, outsourcing dependencies is fine? On Dec 18, 2013 9:34 PM, "Dieter Plaetinck" notifications@github.com wrote:

Sure. GE should be more packaging friendly. I just prioritize my time on core features for now. Any help would be appreciated!

— Reply to this email directly or view it on GitHubhttps://github.com/vimeo/graph-explorer/issues/79#issuecomment-30877937 .

Dieterbe commented 10 years ago

i've personally run into a few cases of dependency-hell and things not being avaliable (or way outdated) when using pypi and such, that's why i generally avoid them. (also python packagement itself is in such a bad shape right now that that's already a reason to avoid it) but i also know that the current GE installation approach is sloppy.

i don't know what the right answer is, i would be fine with supporting pypi and such if it doesn't at least break the current installation method. in addition, i'm very interested in things like omnibus and fpm where you can easily have rpm/deb/whatever packages of GE and all of its dependencies. that's the solution i'm leaning towards the most at this point. but any input is welcome :)

offlinehacker commented 10 years ago

I do understand you so i respect the decision. Right now i'm working on a tool that auto generates python packages for our linux distro, nixos, and i know all the different hacks i had to make to, make it work, i will still make a setup.py so i can put this in distro ;) On Dec 18, 2013 11:50 PM, "Dieter Plaetinck" notifications@github.com wrote:

i've personally run into a few cases of dependency-hell and things not being avaliable (or way outdated) when using pypi and such, that's why i generally avoid them. (also python packagement itself is in such a bad shape right now that that's already a reason to avoid it) but i also know that the current GE installation approach is sloppy.

i don't know what the right answer is, i would be fine with supporting pypi and such if it doesn't at least break the current installation method. in addition, i'm very interested in things like omnibus and fpm where you can easily have rpm/deb/whatever packages of GE and all of its dependencies. that's the solution i'm leaning towards the most at this point. but any input is welcome :)

— Reply to this email directly or view it on GitHubhttps://github.com/vimeo/graph-explorer/issues/79#issuecomment-30889327 .

nikicat commented 10 years ago

+1

Dieterbe commented 10 years ago

we now have a setup.py, i guess i just need to push it to pypi

Dieterbe commented 10 years ago

actually first we need to fix #105 if any of you is good with python setuptools, any help with #105 would be appreciated. once that's fixed i can push to pypi

Dieterbe commented 10 years ago

done and done! https://pypi.python.org/pypi/graph-explorer i installed it locally and seems to work fine. let me know if anything's wrong! i'll make this a habit and push new versions as i make releases in git.

so happy that i've finally learned how to use virtualenv, setuptools and pypi :)

Dieterbe commented 10 years ago

also just revamped the install instructions in the readme for all this new stuff, feel free to give it a checkup :)

offlinehacker commented 10 years ago

Nice :) Will add it to our linux distro (nixos) and report you if i will have any problems with packaging it :)

On Wed, Apr 30, 2014 at 9:23 PM, Dieter Plaetinck notifications@github.comwrote:

also just revamped the install instructions for all this new stuff, feel free to give it a checkup :)

— Reply to this email directly or view it on GitHubhttps://github.com/vimeo/graph-explorer/issues/79#issuecomment-41838562 .