search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

support sharded graphite using metrics/expand instead of index.json #80

Closed nikicat closed 6 years ago

nikicat commented 10 years ago

Review on Reviewable

Dieterbe commented 10 years ago

looks like we should use https://github.com/graphite-project/graphite-web/pull/329

Dieterbe commented 10 years ago

so graphite-project/graphite-web#550 was never merged, but graphite-project/graphite-web#329 is

I think the only thing we should do is request index.json?cluster=1 instead of just index.json

deejay1 commented 9 years ago

index.json?cluster=1 is not supported in all infrastructure types, IMHO there should be a fallback if index.json returns [ ] for discovery using metrics/find or metrics/expand as at least the first one works at our setup (I haven't checked the second one yet)

Dieterbe commented 9 years ago

can you explain in which cases index.json?cluster=1 works and in which it doesn't?