need to update unit and target_type when we do things such as deriving and integrating

vimeo / graph-explorer

A graphite dashboard powered by structured metrics

http://vimeo.github.io/graph-explorer/

Apache License 2.0

1.06k stars 93 forks source link

need to update unit and target_type when we do things such as deriving and integrating #83

Open Dieterbe opened 10 years ago

Dieterbe commented 10 years ago

this probably already mostly works, but not all cases. for example a target with unit=Pckt, target_type=counter (a statsd packets received metric), when I query for unit=Pckt/s it shows up with the correct unit on the Y-axis but target_type still says counter, causing javascript to prefix with "total"

since this target has been modified with a derivative, target_type should become a rate.

we should also make sure that when we integrate rates, they become gauges (or counters?) @thepaul

Dieterbe commented 10 years ago

(note that i just noticed that statsd' packets_received metrics are actually counts, not counters. i.e. they are a minutely count of how many packets seen that resets to 0 at every new datapoint interval, i'll have to fix that)