WyattCast44 commented 5 years ago

Updating the publishable configuration file to use environment variables brings this package in line with how Laravel users generally work. Additionally, hard coding the values in the config file itself is a bad day waiting to happen.

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov-io commented 5 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     96.36%   96.36%           
  Complexity       20       20           
=========================================
  Files             4        4           
  Lines            55       55           
=========================================
  Hits             53       53           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ab876...cb23e43. Read the comment docs.

erunion commented 5 years ago

Released to v5.2.1. Thank you!

vimeo / laravel

Update config file to use environment variables #44

Codecov Report