search

vimeo / laravel

A Vimeo bridge for Laravel
https://developer.vimeo.com
Apache License 2.0
395 stars 89 forks source link

Laravel 6.0 support #59

Open azimidev opened 5 years ago

azimidev commented 5 years ago

Any chance you can make this package compatible for Laravel 6 and publish in packagist as soon as you can

jnbn commented 5 years ago

Just opened a PR on https://github.com/vimeo/laravel/pull/60

BryanMootoosamy commented 5 years ago

Actually, just bumping the version is not enough. Vimeo/laravel use the package vimeo/vimeo-api that use ankitpokhrel/tus-php locked to version 0.1.0. The problem is, ankitpokhrel/tus-php 0.1.0 require Carbon 1 and not Carbon 2 that is the main requirement of laravel 6

asterism612 commented 4 years ago

not supported yet. when support laravel6?

jnbn commented 4 years ago

@asterism612 after the last PR it should work. Can you please define what's wrong about it?

azimidev commented 4 years ago

I still get this 

vimeo/laravel 5.4.0 requires illuminate/contracts ^5.8 -> satisfiable by illuminate/contracts[v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].
jnbn commented 4 years ago

I've changed it on https://github.com/vimeo/laravel/blob/76c9cc73317bfe3c41324a9721c35dd3f4af13f9/composer.json#L19 so there should't be a problem.

azimidev commented 4 years ago

I can see that, also it's been merged, hasn't it? However, has it been tagged? Because I am using 

 "vimeo/laravel": "^5.4"

in composer.json file. is that correct? if so, I still get this error!

jnbn commented 4 years ago

Oh I see.

@muglug can you please tag and release latest commits on master as 5.4.1 ?

jnbn commented 4 years ago

@hassanazimi can you try using dev-master on your composer for now?

azimidev commented 4 years ago

can't do that! composer stops working when updating! My whole app upgrade stuck because of this!

diegosm commented 4 years ago

Maybe the problem is only on 'how' it was tagged for packagist. I used ... "vimeo/laravel": "dev-master"

and works fine for me until this moment.

azimidev commented 4 years ago

Well for me when I use

"vimeo/laravel": "dev-master"

and I run composer update, composer hangs and sticks!

jnbn commented 4 years ago

I suggest deleting your composer.lock and try composer install while keeping vimeo/laravel on dev-master as it is.

jnbn commented 4 years ago

@muglug can you please tag and release latest commits on master as 5.4.1 ?

Still no support for Laravel 6.

mkuzmych commented 4 years ago

Same problem:

Is there any issue? Thanks!

mkuzmych commented 4 years ago

@hassanazimi hassanazimi are You found a solution of this problem?

mkuzmych commented 4 years ago

My fix for problem: in composer.json: "minimum-stability": "dev", "prefer-stable": true then /usr/local/bin/composer require vimeo/laravel:dev-master

azimidev commented 4 years ago

@uapixart Thanks your solution worked for me.