search

vimeo / laravel

A Vimeo bridge for Laravel
https://developer.vimeo.com
Apache License 2.0
401 stars 88 forks source link

Laravel 6 support #60

Closed jnbn closed 5 years ago

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     94.73%   94.73%           
  Complexity       21       21           
=========================================
  Files             4        4           
  Lines            57       57           
=========================================
  Hits             54       54           
  Misses            3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86d8e99...ad2afdb. Read the comment docs.

azimidev commented 5 years ago

Guys, can you review and tag this, please? Thx

chapeladmin commented 5 years ago

Laravel 6 also drops Carbon 1 support. Until vimeo-api updates ankitpokhrel/tus-php dependency to a more recent version supporting Carbon 2, this won't suffice. See https://github.com/vimeo/vimeo.php/issues/208. Also Laravel 6 needs illuminate/* dependencies bumped up to 6.

chapeladmin commented 5 years ago

There's a pull request on vimeo-api https://github.com/vimeo/vimeo.php/pull/211 that will fix the Carbon dependency, but looks like there's a CLA issue of some sort preventing completion.