vimeo / laravel

A Vimeo bridge for Laravel
https://developer.vimeo.com
Apache License 2.0
399 stars 88 forks source link

Laravel 10.x Compatibility #99

Closed laravel-shift closed 1 year ago

laravel-shift commented 1 year ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 10.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 1 year ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift commented 1 year ago

:warning: Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

laravel-shift commented 1 year ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "vimeo/laravel": "dev-l10-compatibility",
    }
}

Finally, run: composer update

Tofandel commented 1 year ago

@laravel-shift This warning should not appear if the laravel/framework is in require-dev, as it's to run unit tests and not an actual dependency

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

jasonmccreary commented 1 year ago

Not necessarily. Even for testing purpose, you'd get this through orchestra/testbench. So the explicit requirement would only be needed if you were trying to pin an exact version of Laravel.

aaronm67 commented 1 year ago

This was merged as #100

ghost commented 1 year ago

can i use facebook-graph-sdk on laravel 10?