search

vimeo / player.js

Interact with and control an embedded Vimeo Player.
https://player.vimeo.com/api/demo
MIT License
1.43k stars 261 forks source link

Doesn't work in IE11 `Object doesn't support property or method 'includes'` #323

Closed denieler closed 5 years ago

denieler commented 5 years ago

Actual Behavior

There is the error in console for IE 11:

Doesn't work in IE11Object doesn't support property or method 'includes'` player.js (2,249087)

Steps to Reproduce

Just run video in IE11, reproducing even on api/demo page of Vimeo.

ricardodrummond commented 5 years ago

I need that fix too. Video doesn't play at all.

fisherinnovation commented 5 years ago

This should be corrected now. Thanks for reporting. Please reopen if you are still noticing this issue.

denieler commented 5 years ago

@fisherinnovation was it a release in the last few hours? Or how it should be fixed?

ricardodrummond commented 5 years ago

It looks like it's working.

fisherinnovation commented 5 years ago

@denieler It was a player update not an API update. No change is required on your end.

rajeevmehrotra commented 5 years ago

Looks like this issue is back. player.js has the includes method again.

Version I'm getting from the CDN is Vimeo Player v3.5.3 link

idMolotov commented 5 years ago

@denieler

can you check that you have all required for the IE11 shims and polyfill's added to the imports/load

import 'core-js/es6/map';
import 'core-js/es6/set';
import 'babel-polyfill';
....