vimeo / player.js

Interact with and control an embedded Vimeo Player.
https://player.vimeo.com/api/demo
MIT License
1.45k stars 262 forks source link

Non-passive event listener chrome warnings #553

Closed megan-parkes-sonocent closed 7 months ago

megan-parkes-sonocent commented 4 years ago

Hi,

We're seeing some warnings appear in chrome when using this module. The warnings are viewable on https://player.vimeo.com/api/demo in chrome v80.

Can the listeners be made passive or are the non passive event listeners required? Screenshot 2020-04-03 at 16 14 50

player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
Kf.addEvent @ player.js:10
Kf.addEvent @ player.js:10
$f @ player.js:10
Kf.on @ player.js:10
Ct @ player.js:10
ov @ player.js:10
(anonymous) @ player.js:10
initializationHandler @ player.js:10
(anonymous) @ player.js:10
player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
Kf.addEvent @ player.js:10
Kf.addEvent @ player.js:10
$f @ player.js:10
Kf.on @ player.js:10
(anonymous) @ player.js:10
av @ player.js:10
(anonymous) @ player.js:10
initializationHandler @ player.js:10
(anonymous) @ player.js:10
player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
martinweck commented 4 years ago

+1 I have got those warnings, too. Please fix them:

player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
nl.addEvent @ player.js:10
nl.addEvent @ player.js:10
tl @ player.js:10
nl.on @ player.js:10
Ct @ player.js:10
iv @ player.js:10
(anonymous) @ player.js:10
initializationHandler @ player.js:10
(anonymous) @ player.js:10
player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
nl.addEvent @ player.js:10
nl.addEvent @ player.js:10
tl @ player.js:10
nl.on @ player.js:10
(anonymous) @ player.js:10
rv @ player.js:10
(anonymous) @ player.js:10
initializationHandler @ player.js:10
(anonymous) @ player.js:10
player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
nl.addEvent @ player.js:10
nl.addEvent @ player.js:10
tl @ player.js:10
nl.on @ player.js:10
Qv @ player.js:10
(anonymous) @ player.js:10
initializationHandler @ player.js:10
(anonymous) @ player.js:10
player.js:10 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
luwes commented 4 years ago

thanks for the feedback! we will look into this

jpowell commented 4 years ago

We've run into this as well. Check this out: https://web.dev/uses-passive-event-listeners/

Seems like an easy fix πŸŽ‰

abombelli commented 4 years ago

Same issue here.

luwes commented 4 years ago

we released a fix with explicit passive properties for the events. looks like this is resolved πŸŽ‰ please let us know if you see any issues

brown2020 commented 2 years ago

This issue is back with the Vimeo player:

Screen Shot 2022-07-20 at 8 59 31 AM
Nicholasbell03 commented 1 year ago

Can confirm I am receiving the issue with Vimeo player 2.20.1

chrish123 commented 1 year ago

I can confirm the same issue using embed code: image

alexberdejo7 commented 11 months ago

mismo problema

MatteoBruschetti commented 9 months ago

Same problem with VimeoPlayer - v4.27.3 - 2024-01-24

kirilreznik commented 9 months ago

I am experiencing the same issue - "@vimeo/player": "2.19.0"

rkrishnan8594 commented 9 months ago

For those still experiencing this issue, could you provide steps for reproduction, as well as a description of the end user impact?