search

vimeo / psalm

A static analysis tool for finding errors in PHP applications
https://psalm.dev
MIT License
5.56k stars 660 forks source link

Add support for `nikic/php-parser` version 5+ #11112

Open michnovka opened 4 weeks ago

michnovka commented 4 weeks ago

Because of psalm depending on nikic/php-parser ^4.17.0, I cannot use phpunit 11, as that requires "phpunit/php-code-coverage": "^11.0.6" which in turn requires "nikic/php-parser": "^5.1.0"

The conflict I have is clear here:

$ composer why nikic/php-parser
phpunit/php-code-coverage 9.2.32  requires  nikic/php-parser (^4.19.1 || ^5.1.0) 
sebastian/complexity      2.0.3   requires  nikic/php-parser (^4.18 || ^5.0)     
sebastian/lines-of-code   1.0.4   requires  nikic/php-parser (^4.18 || ^5.0)     
symfony/maker-bundle      v1.61.0 requires  nikic/php-parser (^4.18|^5.0)        
vimeo/psalm               5.26.1  requires  nikic/php-parser (^4.17)             
vimeo/psalm               5.26.1  conflicts nikic/php-parser (4.17.0)
psalm-github-bot[bot] commented 4 weeks ago

Hey @michnovka, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

michnovka commented 4 weeks ago

This issue does not apply to psalm syntax check, but rather dependencies

kochen commented 3 weeks ago

@michnovka work has started here: https://github.com/vimeo/psalm/pull/11035