False positive with PropertyNotSetInConstructor

[BenMorel]

Consider the following code:

final class Uuid
{
    private string $value;

    public function __construct(string $value)
    {
        if (static::isValid($value)) {
            $this->value = 'foo';
            return;
        }

        throw new InvalidArgumentException('Provided UUid is invalid');
    }

    public static function isValid(string $value): bool
    {
        return preg_match('/whatever/', $value) === 1;
    }
}

Psalm reports:

ERROR: PropertyNotSetInConstructor - 7:20 - Property Uuid::$value is not defined in constructor of Uuid and in any private or final methods called in the constructor

I believe this is a false positive, as the constructor can only return when the value has been set.

Reproduce: https://psalm.dev/r/7a6e02239a

[psalm-github-bot[bot]]

I found these snippets:

https://psalm.dev/r/7a6e02239a

```php value = 'foo'; return; } throw new InvalidArgumentException('Provided UUid is invalid'); } public static function isValid(string $value): bool { return preg_match('/whatever/', $value) === 1; } } ``` ``` Psalm output (using commit d19088b): ERROR: PropertyNotSetInConstructor - 5:20 - Property Uuid::$value is not defined in constructor of Uuid and in any private or final methods called in the constructor ```

[weirdan]

Equivalent code with an inverted if is fine: https://psalm.dev/r/627a5cbd29

[psalm-github-bot[bot]]

I found these snippets:

https://psalm.dev/r/627a5cbd29

```php value = 'foo'; } public static function isValid(string $value): bool { return preg_match('/whatever/', $value) === 1; } } ``` ``` Psalm output (using commit d19088b): No issues! ```

[BenMorel]

@weirdan Yep. It would be nice if it worked both ways!