vimeo / vimeo.py

Official Python library for the Vimeo API.
https://developer.vimeo.com
Apache License 2.0
210 stars 84 forks source link

Support any new version of tus-py-client #137

Closed awartani closed 6 years ago

awartani commented 6 years ago

Hey!

I have an issue when I tried to install vimeo.py via pipenv:

Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
  You can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
  Hint: try $ pipenv lock --pre if it is a pre-release dependency.
Could not find a version that matches certifi==2017.7.27.1,==2018.8.24,>=2017.4.17 (from -r pipenv-ppekn1cn-constraints.txt (line 44))
Tried: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 1.0.0, 1.0.1, 1.0.1, 14.5.14, 2015.4.28, 2015.4.28, 2015.9.6, 2015.9.6, 2015.9.6.1, 2015.9.6.1, 2015.9.6.2, 2015.9.6.2, 2015.11.20, 2015.11.20, 2015.11.20.1, 2015.11.20.1, 2016.2.28, 2016.2.28, 2016.8.2, 2016.8.2, 2016.8.8, 2016.8.8, 2016.8.31, 2016.8.31, 2016.9.26, 2016.9.26, 2017.1.23, 2017.1.23, 2017.4.17, 2017.4.17, 2017.7.27, 2017.7.27, 2017.7.27.1, 2017.7.27.1, 2017.11.5, 2017.11.5, 2018.1.18, 2018.1.18, 2018.4.16, 2018.4.16, 2018.8.13, 2018.8.13, 2018.8.24, 2018.8.24
There are incompatible versions in the resolved dependencies.

See how certifi was added in tuspy==0.2.1: https://github.com/tus/tus-py-client/blob/v0.2.1/setup.py#L16 and comparing to how it's loaded in the latest version https://github.com/tus/tus-py-client/blob/master/setup.py#L12

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Onebrownsound commented 6 years ago

@awartani We were using tuspy>=0.2.1, but unbeknownst to us it anything >0.2.2 contains breaking changes for Python 2.7. So we've opted to lock tuspy at 0.2.1.

awartani commented 6 years ago

Thanks, @Onebrownsound.

I don't know about any better way to resolve pipenv issue, so I'll continue to use this fork as my source, keeping the PR open might help other people but I don't know what's the best way to handle this.

That's said, please feel free to close this PR.