search

vimperator / vimperator-labs

Vimperator
http://vimperator.org
Other
1.19k stars 195 forks source link

ContentSeparator global instead of per window #464

Open SammysHP opened 8 years ago

SammysHP commented 8 years ago
Issue type:
Vimperator: 3.12.0 (created: 2016/03/02 13:30:53)
Firefox:    Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Description:

Opening two windows of Firefox on different screens and setting one to fullscreen hides the statusbar and removes the ContentSeparator on the fullscreen window as expected but also removes the ContentSeparator from the other window.

Expected behavior:

ContentSeparator is removed only from the window that is fullscreen.

Steps to reproduce:

ContentSeparator is removed via highlight.set('ContentSeparator', …) which is global (see https://github.com/vimperator/vimperator-labs/blob/master/common/content/statusline.js#L155).

I don't know if there's an easy way to fix this without rewriting the styling implementation.

gkatsev commented 8 years ago

That's also probably one of the issues we have with respect to e10s. All of our stuff are global and not per-window.