search

vimperator / vimperator-labs

Vimperator
http://vimperator.org
Other
1.19k stars 196 forks source link

set gui=notabs has no effect #544

Open miblodelcarpio opened 8 years ago

miblodelcarpio commented 8 years ago
Issue type:
Vimperator: 3.14.0 (created: 2016/06/07 23:58:16)
Firefox:    Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Description:

When using set gui=notabs in ~/.vimperatorrc, the setting does not take effect. Running that same set command from within Firefox, however, does apply the setting. Also, using set gui=none in ~/.vimeratorrc hides everything except for the tabs.

Expected behavior:

I'd expect the tab bar not to be displayed upon launch.

Steps to reproduce:

Write set gui=notabs in ~/.vimperatorrc and launch Firefox.

SammysHP commented 8 years ago

For me at least set gui=none in ~/.vimeratorrc hides everything including tabs.

Vimperator: 3.14.0 (created: 2016/06/30 11:33:16)
Firefox:    Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
miblodelcarpio commented 8 years ago

Alright, knowing that it doesn't affect everyone, I've investigated some more.

  1. After launching Firefox, opening a New Private Window makes the set gui=none setting from ~/.vimperatorrc hide the tab bar as expected
  2. Disabling the Tab Mix Plus extension makes set gui=none hide the tab bar on first launch

I don't know how extensions are loaded at all, but the issue seems to be a conflict between Vimperator and Tab Mix Plus on launch, perhaps with Vimperator loading first and then Tab Mix Plus coming along and overriding Vimperator's work.

I'll keep Tab Mix Plus disabled for now, but I can see a use case for both extensions – and set gui=none – being enabled together.

joe9 commented 7 years ago

Probably related, set gui=tabs has no effect when Tree Style Tab is enabled.