Distinction between Vimperator and Muttator

SammysHP commented 7 years ago

I just wanted to implement a new feature that is Firefox-only and wondered where I should start. Most code is in common/content which is shared between Vimperator and Muttator.

Actually lots of code in common is not meant for Thunderbird/Muttator. Even worse: There are version checks in it that compare the version number (e.g. common/content/sanitizer.js#L111) without any distinction between Firefox and Thunderbird.

What should we do? Firefox and Thunderbird divert even more with time. I wonder if Vimperator can exist in the future (e.g. multi process) while keep sharing code with Thunderbird.

maxauthority commented 7 years ago

Yeah, that's a very interesting question. I personally haven't used Muttator for quite a while, so I am very impressed if it actually still works. For now the stance was to not deliberatly break Muttator, but even with some small quirks it's better not to abandon Muttator fully.

If Vimperator was rewritten as an WebExtension, then I think it's quite clear that Muttator would need to be dropped (did they even announce WebExtensions for Thunderbird?). On the other hand, if your new feature (what is it?, just being curious ;)) warrants a seperate file, then putting that in vimperator/content/ instead of common/content/ would probably be better.

Martin

On Fri, Oct 14, 2016 at 8:42 PM, SammysHP notifications@github.com wrote:

I just wanted to implement a new feature that is Firefox-only and wondered where I should start. Most code is in common/content which is shared between Vimperator and Muttator.

Actually lots of code in common is not meant for Thunderbird/Muttator. Even worse: There are version checks in it that compare the version number (e.g. common/content/sanitizer.js#L111 https://github.com/vimperator/vimperator-labs/blob/8f0025eef320846d210ee97b02a38973f7cbb13a/common/content/sanitizer.js#L111) without any distinction between Firefox and Thunderbird.

What should we do? Firefox and Thunderbird divert even more with time. I wonder if Vimperator can exists in the future (e.g. multi process) while keep sharing code with Thunderbird.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vimperator/vimperator-labs/issues/617, or mute the thread https://github.com/notifications/unsubscribe-auth/AFtBr9-k25PLGKUbrcU-6zDoK33nYap7ks5qz80UgaJpZM4KXUgt .

SammysHP commented 7 years ago

what is it?, just being curious ;)

It's #619 which I already implemented in #620. I just added the new option to vimperator/content/config.js.

petelewis commented 7 years ago

Please don't abandon muttator :-)

I only wish it had proper Vim integration. I was wondering if that might even be feasible now with neovim...

On 16 October 2016 18:15:21 BST, Martin Stubenschrott notifications@github.com wrote:

Yeah, that's a very interesting question. I personally haven't used Muttator for quite a while, so I am very impressed if it actually still works. For now the stance was to not deliberatly break Muttator, but even with some small quirks it's better not to abandon Muttator fully.

If Vimperator was rewritten as an WebExtension, then I think it's quite clear that Muttator would need to be dropped (did they even announce WebExtensions for Thunderbird?). On the other hand, if your new feature (what is it?, just being curious ;)) warrants a seperate file, then putting that in vimperator/content/ instead of common/content/ would probably be better.

Martin

On Fri, Oct 14, 2016 at 8:42 PM, SammysHP notifications@github.com wrote:

I just wanted to implement a new feature that is Firefox-only and wondered where I should start. Most code is in common/content which is shared between Vimperator and Muttator.

Actually lots of code in common is not meant for Thunderbird/Muttator. Even worse: There are version checks in it that compare the version number (e.g. common/content/sanitizer.js#L111

https://github.com/vimperator/vimperator-labs/blob/8f0025eef320846d210ee97b02a38973f7cbb13a/common/content/sanitizer.js#L111) without any distinction between Firefox and Thunderbird.

What should we do? Firefox and Thunderbird divert even more with time. I wonder if Vimperator can exists in the future (e.g. multi process) while keep sharing code with Thunderbird.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vimperator/vimperator-labs/issues/617, or mute the thread

https://github.com/notifications/unsubscribe-auth/AFtBr9-k25PLGKUbrcU-6zDoK33nYap7ks5qz80UgaJpZM4KXUgt .

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/vimperator/vimperator-labs/issues/617#issuecomment-254059873

ghost commented 7 years ago

@maxauthority Make new muttator release please.

maxauthority commented 7 years ago

Yeah, sounds like a good idea. I'll also give @gkatsev owner rights on addons.mozilla.org so he can also make releases as he likes :) I just need to first find out, how to login to addons.mozilla.org first, as my usual username/password combo doesn't work anymore but it asks for a "Firefox account" with an email address (and mine isn't found). Has anybody had the same issue and do I really need to create (and associate) a new Firefox account?

SammysHP commented 7 years ago

I got a mail some weeks ago to migrate my account. Here's a help article:

https://support.mozilla.org/en-US/kb/access-your-add-ons-firefox-accounts

maxauthority commented 7 years ago

Oh, must have missed that! Thanks a lot! Will do it tomorrow or so, and then add (at least) @gkatsev to the "people with power" on AMo for Muttator, so future updates should be much more reliable if it is not depending on a single person.

maxauthority commented 7 years ago

Ok, I tried releasing Muttator 1.4, but it didn't pass the review :( They seem to get more strict about the usage of eval. Wondering though, why Vimperator 3.15 was accepted with the same usage. Maybe we just had "bad luck", but still not sure, how to continue best:

Hello,

Your add-on, Muttator 1.4, has been reviewed and did not meet the criteria for being hosted in our gallery.

Reviewer: Leszek Ż****

Comments: This version didn't pass review because of the following problems:

We generally don't accept using the 'eval' function. There are many reasons not to use 'eval', and there are alternatives available. You can read more about it here: https://developer.mozilla.org/en/XUL_School/Appendix_C:_Avoid_using_eval_in_Add-ons

This version of your add-on has been disabled. You may re-request review by addressing the reviewer's comments and uploading a new version at https://addons.mozilla.org/en-US/developers/addon/muttator/versions

If you want to respond to this review, or have any questions about it, please reply to this email or join #amo-editors on irc.mozilla.org.

To learn more about the review process, please visit https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews

Mozilla Add-ons Team https://addons.mozilla.org

vimperator / vimperator-labs

Distinction between Vimperator and Muttator #617

Ok, I tried releasing Muttator 1.4, but it didn't pass the review :( They seem to get more strict about the usage of eval. Wondering though, why Vimperator 3.15 was accepted with the same usage. Maybe we just had "bad luck", but still not sure, how to continue best:

To learn more about the review process, please visit https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews