Support latest GHC (and latest stackage nightly)

vimus / libmpd-haskell

A client library for MPD, the Music Player Daemon

MIT License

36 stars 26 forks source link

Support latest GHC (and latest stackage nightly) #113

Closed psibi closed 5 years ago

psibi commented 5 years ago

This PR should be properly reviewed as I have only made sure that it compiles fine and the test suites are passed.

Summary of the changes:

Only support latest 4 major GHC's. With xmonad also doing the same, I made the same decision here.
In recent version of network (>= 3.0), the connectTo function isn't present. So, safeConnect function has been changed accordingly. (This is the part that need review from the person actually using the library).

joachifm commented 5 years ago

Thank you

psibi commented 5 years ago

@joachifm Can a new hackage release be made ?

joachifm commented 5 years ago

@psibi sure. Unfortunately I currently have no time for this project; if you care to, a release is basically: pick fixes to libmpd-0.9 branch, bump version, tag it, upload new archive to Hackage.

psibi commented 5 years ago

@joachifm Yes, I could do that. But I don't think I have access to upload it to Hackage.

joachifm commented 5 years ago

@psibi I could add you to the maintainer group, if you have a Hackage user account.

psibi commented 5 years ago

@joachifm My hackage account name is psibi: https://hackage.haskell.org/user/psibi

joachifm commented 5 years ago

@psibi added

psibi commented 5 years ago

@joachifm Thanks, I will do a release this weekend.

joachifm commented 5 years ago

Sounds good. Thank you