search

vimus / libmpd-haskell

A client library for MPD, the Music Player Daemon
MIT License
36 stars 26 forks source link

Omit Volume constructor from Show instance #118

Closed haasn closed 4 years ago

haasn commented 4 years ago

The derived show instance shows a Volume 50 as "Volume 50", but I think showing it as "50" makes more sense and is slightly more convenient for users of the library.

YMMV

haasn commented 4 years ago

Motivating use case here is vimus, which uses show on types of Volume to build the status line. Since this newtype was added, it now shows vol: Volume 50 instead of vol: 50.

Not a huge deal since we can just fromIntegral the newtype away, but I thought I might still fix this in libmpd rather than vimus.

psibi commented 4 years ago

Thanks!