search

vimus / libmpd-haskell

A client library for MPD, the Music Player Daemon
MIT License
36 stars 26 forks source link

Proposal: deprecate <&> #126

Closed iyefrat closed 3 years ago

iyefrat commented 3 years ago

To my understanding, <&> was only needed as a substitute for <> on versions of ghc too old to have Semigroup, which have been unsupported since #113. It conflicts with the <&> operator in base (under Data.Functor) as well. To this end, I propose that it be deprecated now, and removed in the next major version (presumably 0.10).

If you accept my proposal, I also suggest that the 0.9.2.0 release be made shortly after, so the deprecation notice can be available for as long as possible.

iyefrat commented 3 years ago

It seems that the second commit broke the CI on ghc<8.4. I will fix this sometime in the next few days. I'm also going to send a MR similar to #113 to add tests for the newer ghc's and drop support for ghc<8.4 regardless, but still.

iyefrat commented 3 years ago

@psibi fixed

psibi commented 3 years ago

Thanks!

psibi commented 3 years ago

A new release has been made to Hackage.

iyefrat commented 3 years ago

Sweet, thanks!