search

vimus / libmpd-haskell

A client library for MPD, the Music Player Daemon
MIT License
36 stars 26 forks source link

Upload fixed build to hackage #142

Closed cbrt-x closed 3 months ago

cbrt-x commented 3 months ago

The version currently on hackage (10.0.0) does not currently build. The fixed version should be uploaded (presumably under 10.0.1)

I have no experience with hackage but would be willing to do this task if I had the rights for it.

@joachifm (if you don't have time currently, don't feel pressured to do anything immediately)

joachifm commented 3 months ago

The version currently on hackage (10.0.0) does not currently build. The fixed version should be uploaded (presumably under 10.0.1)

I have no experience with hackage but would be willing to do this task if I had the rights for it.

I can add your Hackage user to the list of package maintainers

cbrt-x commented 3 months ago

My hackage username is Jade512

joachifm commented 3 months ago

My hackage username is Jade512

I have added you to the list of package maintainers

joachifm commented 3 months ago

Might make sense to look into using something like https://github.com/haskell-actions/hackage-publish to automate this. More convenient and also more transparent than uploading random artifacts.

cbrt-x commented 3 months ago

@joachifm cabal check is complaining about the -Wall and -Werror not being portable cpp-options. Is there a specific rationale for passing them or can I safely remove them? I'm not really sure what warnings you'd get from the C-compiler anyways.

joachifm commented 3 months ago

If I remember correctly, we rely on the C pre-processor to conditionally expose some internals when building the test-suite.

I don't know why -Wall and -Werror flags were added to cpp-options, but I expect that removing them should be okay.

cbrt-x commented 3 months ago

libmpd 0.10.0.1 has been released