search

vimuthm / pe

0 stars 0 forks source link

[DG] Ui class diagram not updated #11

Open vimuthm opened 2 years ago

vimuthm commented 2 years ago

I noticed that there's added components to the MainWindow such as TabOption. This is not represented. It leaves out some important info for dev who want to work on the ui, so I will consider this a low severity.

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

Hi there,

TabOption is not part of our MainWindow. We can take a look at the code in MainWindow.java and we would notice that there is no use/mention of TabOption in that file. Hence we believe that the reported bug added components to the MainWindow such as TabOption. This is not represented. is not a valid. We will be rejecting this bug find.

Thank you! ^_^

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, thanks for the response! I see that MainWindow does not make use of TapOption. But I do like to also point out that my main concern was that the UI class diagram was not updated (titled) and this was just an example I described (a mistake on my part). Considering this and also:

  1. All 3, AnimeListPanel.java, the Model and Logic (which are in the diagram) have associations to TabOptions

  2. TabOptions is a crucial part of the UI that must be included the UI class diagram or minimally in the proceeding description

  3. It's a major feature your team added (I personally like this a lot xD), as also shown in the Effort section of your DG, I think the UI must have some reference to tabs to indicate to developers that this at least exists.

Thus, I think that the UI class diagram is indeed not updated and feel this is a legitimate issue to developers who read the UI section.

Best Regards!