vimuthm / pe

0 stars 0 forks source link

Constraint-Human-Editable-File not workable #6

Open vimuthm opened 2 years ago

vimuthm commented 2 years ago

Under this constraint, I modified the json file and set a genre to scifi without a whitespace.

image.png

On re-open all the data was wiped!

image.png

This is a bug, because you cant expect the user to edit it into a valid format.

nus-pe-bot commented 2 years ago

Team's Response

From AniList Devs:

We can and should expect the users to edit the files to the valid format as based on the constraints laid out in the Module Website. Changing .json files is only for advanced users and we are to expect advanced users to be able to change things properly.

image.png

For advanced users, should such a case happen, they are still able to retrieve the previous data by obtaining the datafile prior to quitting the application. Since the data can still be recovered and this is an issue only for advanced users, this no longer serves as a bug find. We would once again expect the advanced users to edit internal saved files with caution. Besides that, the program did not crash which, if that were to be the case, would make this an acceptable bug. We have brought down the severity to low as we do not believe that this is a concern for most users. We are also changing this to a Feature Flaw as it is not a feature that was explicitly implemented.

Follow the issue shown in this link, https://github.com/nus-cs2103-AY2021S1/pe-dev-response/issues/5290 we will still be rejecting this bug due to the reasons stated above.

Best Regards!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: Thanks for your response! Although I will be accepting this as rejected, I want to point out that neither the UG nor DG mention the ability to edit the json and that mainly it is to be done with caution or the fact that valid data should be provided.

This essentially makes it a functionality bug since it is not mentioned in the documentation and as a user, I would expect it to do the required validation checking.


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]