search

vimuthm / pe

0 stars 0 forks source link

[DG] Use case - Unnecessary/repeated information #9

Open vimuthm opened 2 years ago

vimuthm commented 2 years ago

1a -> 1e is mostly repetitive, I think they can be combined appropriately.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Hi there,

The use cases here show the process in which the program takes to result in the error. As the system carries our different steps to achieve the error message, we felt that it is better for us to show them as different extensions rather than to pile them into one use case that returns an error message. It is important to note that this is still within what is allowable for a use case. We hope this clarifies the usage of multiple extensions on this regard. We will not be accepting this bug.

Thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response! I disagree based on the following points:

  1. With regard to:

As the system carries our different steps to achieve the error message

I noticed that it's a matter of calling the parse method of each the respective classes as shown in the snippet from your AddCommandParser.java file. So I don't think this point stands.

image.png

And for:

It is important to note that this is still within what is allowable for a use case

It is said that unnecessary details and mainly repetitive ones are indeed bugs:

image.png

Also note that although, I screenshotted one use case, this repetition of separating invalid parameters is repeated throughout multiple use cases and makes the DG more clunky than need be.

This is my basis for believing that this a legitimate bug.

Best regards!