Closed msansen closed 3 months ago
Fix cases when the url could contain query parameters (eg gitlab links with path)
The fix gets the filename from the server headers content-disposition: attachment; filename="real_filename.zip" and fallback to extracting using basename by removing the query parameter(s): $(basename "${url%%\?*}")
content-disposition: attachment; filename="real_filename.zip"
basename
$(basename "${url%%\?*}")
Hi thanks for the fix @msansen, really nice addition
Fix cases when the url could contain query parameters (eg gitlab links with path)
The fix gets the filename from the server headers
content-disposition: attachment; filename="real_filename.zip"
and fallback to extracting usingbasename
by removing the query parameter(s):$(basename "${url%%\?*}")