vinayvenu / orthanc

Automatically exported from code.google.com/p/orthanc
GNU General Public License v3.0
1 stars 3 forks source link

Unbundle the libraries #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,

I'm planning packaging this software.

However seems it has bundled minizip and some sha1/base64 code.

Can you unbundle them?

I'm packaging for Fedora, Fedora doesn't allow bundled libraries.

Thanks.

Original issue reported on code.google.com by Cickumqt on 18 Jul 2013 at 6:55

GoogleCodeExporter commented 9 years ago
Hi,

Thanks for your interest in Orthanc! Are you aware of the fact that Orthanc is 
already packaged for Fedora?
https://apps.fedoraproject.org/packages/orthanc/

To the best of my knowledge, "minizip" is just a sample code from the standard 
distribution of "zlib" that is not packaged with the Fedora distribution. As 
far as sha1/base64/md5 are concerned, I have not been able to locate them in 
the official Fedora packages.

Original comment by s.jodo...@gmail.com on 18 Jul 2013 at 7:12

GoogleCodeExporter commented 9 years ago
Oh.

JUst notice that it has been packaged(Although I was packaging it for 
self-improvement).

Thanks.

BTW I think cmake shouldn't download the packages which are not in the system, 
it should stop and let user know.

Original comment by Cickumqt on 19 Jul 2013 at 12:01

GoogleCodeExporter commented 9 years ago
"I think cmake shouldn't download the packages which are not in the system, it 
should stop and let user know."

=> This is now the case in the mainline. The CMake options have been strongly 
refactored, and it is now needed to explicitly add "-DALLOW_DOWNLOADS=ON" to 
allow the download of packages from the Internet.

Original comment by s.jodo...@gmail.com on 29 Oct 2013 at 11:59