vinc3leong / pe

0 stars 0 forks source link

Editing tags of patients remove all existing tags #6

Open vinc3leong opened 4 days ago

vinc3leong commented 4 days ago

Editing tags of patients will remove all existing tags feels like a troublesome and flawed implementation. Let's say the hospital has a patient that is tagged with disease1 disease2 disease3 and disease4 and I mis-tag a disease5 to said patient. The only way to undo this action is to run the command edit [patientNRIC] tag/disease1 tag/disease2 tag/disease3 tag/disease4, but this is more work than necessary.

You would need to filter out this patient from the contact list, take note of all existing tags and run the said command above, which in hospitals with thousands of patients and possibly multiple tags on every patients seem like a hassle to do so.

Steps to recreate: 1) add a patient with multiple tags:

{2C34F6BA-E7CE-403F-8C11-F62A14CEC76E}.png

2) run the command edit NRIC tag/cancer4

3) existing tags have all been replaced by cancer4

{D0BA0C86-DBB3-48C1-9248-7C68267C5DC5}.png

soc-pe-bot commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We agree that it is a minor inconvenience when adding tags to a patient who already has multiple tags, however this is something that is stated in our UG that will happen, that the adding of tags to a patient is not cumulative. We could refine this feature in the future by making the editing of tags not cumulative.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]