vincedarley / homebridge-plugin-bwaspa

Control Balboa BWA Spa through Homebridge/Homekit
Apache License 2.0
18 stars 7 forks source link

Current Temperature warning when temp returns null #25

Open danieljbnz opened 1 year ago

danieljbnz commented 1 year ago

Hey there,

Great plugin. Love the 'plug and play' ease of use.

In the Homebridge logs, I am getting a number of entries where the Spa returns a null value for the temperature. This is because the Spa is set to Rest mode, and the temp is not reported in the BWA app.

Is it possible to set a null value to an arbitrary temp when you receive a null value? or just hide the warning in the logs.

Another great feature would be the option to switch full debug logs on/off - when it is off, it just shows the basics of the current Spa state. Also a poll time option would also be great to minimise the number of logs there are.

[16/05/2023, 07:35:47] [homebridge-balboa-spa] This plugin generated a warning from the characteristic 'Current Temperature': characteristic was supplied illegal value: null! Home App will reject null for Apple defined characteristics. See https://homebridge.io/w/JtMGR for more info.

vincedarley commented 1 year ago

Hi - these are good suggestions, thanks. I'll work on these at some point, although (as you'll have noticed) haven't felt a need to make changes to the plugin recently. But I certainly agree the logs could be better, and that some kind of control over logging could be useful. If you have more specific suggestions there, that would be appreciated.

On Mon, 15 May 2023 at 20:50, danieljbnz @.***> wrote:

Hey there,

Great plugin. Love the 'plug and play' ease of use.

In the Homebridge logs, I am getting a number of entries where the Spa returns a null value for the temperature. This is because the Spa is set to Rest mode, and the temp is not reported in the BWA app.

Is it possible to set a null value to an arbitrary temp when you receive a null value? or just hide the warning in the logs.

Another great feature would be the option to switch full debug logs on/off

  • when it is off, it just shows the basics of the current Spa state. Also a poll time option would also be great to minimise the number of logs there are.

[16/05/2023, 07:35:47] [homebridge-balboa-spa] This plugin generated a warning from the characteristic 'Current Temperature': characteristic was supplied illegal value: null! Home App will reject null for Apple defined characteristics. See https://homebridge.io/w/JtMGR for more info.

— Reply to this email directly, view it on GitHub https://github.com/vincedarley/homebridge-plugin-bwaspa/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGGHRYVQTMR2MH2QQIMHU4TXGKCJZANCNFSM6AAAAAAYCU3434 . You are receiving this because you are subscribed to this thread.Message ID: @.***>