search

vincefn / pyvkfft

Python interface to VkFFT
MIT License
51 stars 6 forks source link

Allow offsets in pyopencl arrays #16

Open isuruf opened 2 years ago

vincefn commented 2 years ago

Thanks for the PR. I never use offsets = this corresponds to array pointing to memory allocations with an offset ?

Could you add a corresponding unit test ? Nothing as systematic as the current test, but e.g. like the old version of test like https://github.com/vincefn/pyvkfft/blob/d5eb898164b3a36c2d1b8fc2ccfadfcec2b855cc/test/test_opencl.py ?

isuruf commented 2 years ago

I'm marking this as draft as the test is not working. I'll get back to this soon.