search

vincefn / pyvkfft

Python interface to VkFFT
MIT License
51 stars 6 forks source link

Install not working on MacOS 11.2.1 #3

Closed yves-surrel closed 3 years ago

yves-surrel commented 3 years ago

Hi

Seems very exciting, but

pip install pyvkfft

returns

clang: error: invalid argument '-bundle' not allowed with '-dynamiclib'
vincefn commented 3 years ago

I've only tested on macOS 10.13.6 (clang with Xcode 9.2).

Can you try after removing the --shared option in setup.py ?

yves-surrel commented 3 years ago

@vincefn As you suggested, I changed

        extra_link_args = ['-Wl,-framework,OpenCL', '--shared']

to

        extra_link_args = ['-Wl,-framework,OpenCL']

at line 70 (in locate_opencl).

Fixed, thx

tlambert03 commented 3 years ago

I can also confirm on both macos11 and 10.15 that removing --shared is necessary to build.

vincefn commented 3 years ago

Fixed by e843fdd443. The --shared may still be necessary on older Xcode/llvm compilers