search

vinceh121 / socialblade-api

Unofficial SocialBlade api
GNU General Public License v3.0
19 stars 5 forks source link

Refactor and fixed API #2

Closed ThexXTURBOXx closed 5 years ago

ThexXTURBOXx commented 5 years ago

"isVerified" and "partners" were wrong type

vinceh121 commented 5 years ago

Why did you set the getters in the *Datapoint classes to the package access level?

ThexXTURBOXx commented 5 years ago

Those are interfaces. You don't ever need any visibility modifiers in interface classes. When you implement interfaces, you specify them in the implementing class

vinceh121 commented 5 years ago

Okay I'll convert those to classes later then cause I messed that up.

And thanks for the correction about the types and refactoring

vinceh121 commented 5 years ago

Okay I'll convert those to classes later then cause I messed that up.

And thanks for the correction about the types and refactoring

ThexXTURBOXx commented 5 years ago

Perfect! You're welcome

ThexXTURBOXx commented 5 years ago

Oh, and I just noticed... I suggest you to take a look at https://projectlombok.org/ For APIs like this one, it's a very useful tool! E.g. the class YTStats could look like this then. It makes work really easier ;)

vinceh121 commented 5 years ago

Oh, that's an interesting framework, but I still prefer the old school way...