vinceliuice / Fluent-gtk-theme

Fluent design gtk theme for linux desktops
GNU General Public License v3.0
1.06k stars 59 forks source link

CSS symlinks seems to be incorrect #121

Open HymanZHAN opened 2 years ago

HymanZHAN commented 2 years ago

Again let me first appreciate the work you put into making so many beautiful themes. :bow: I really love your work :heart: and I used them on every single Fedora installation :sparkles: Can't thank you enough! :tada:

There was a little issue I encountered last night: After installing the Fluent theme, I noticed libadwaita apps like gnome-control-center and gnome-sound-recorder does not follow the dark/light preference in the setting at all. Here is a screencast that helps explain the situation:

https://user-images.githubusercontent.com/26806995/186167613-27e94ce9-df89-44c4-9fe0-83486d579fcb.mp4

After some investigation, I found that there is a symlinking process at the end of running ./install.sh:

image

And it seems this is where things went wrong because the result of this linking was quite problematic:

image

There are a couple of issues: a) gtk.css points to the Fluent-Dark theme and b) gtk-dark.css points to a non-existent gtk-dark.css file inside the Fluent-Dark folder. I made a few tweaks but the result wasn't ideal.

It's not a big issue (and probably just something WIP) but hope it could get fixed soon. Thanks!

dayfuaim commented 2 years ago

I insert my 5 cents. ;)

Ubuntu 22.10 beta, GNOME 43.beta, GNOME Shell 43.beta

% ./install.sh -c dark -s compact --tweaks round                                                                                                                 git:(master|)
gnome-shell 42.0
Install rounded windows version ...
Installing '/home/dayfuaim/.themes/Fluent-round-Dark-compact'...

Link '/home/dayfuaim/.themes/Fluent-round-Dark/gtk-4.0' to '/home/dayfuaim/.config/gtk-4.0' for libadwaita...

Done.

I install -compact version of theme, but symlinks are made for normal one (not compact). So I have the following: image

I.e. all symlinks to non-'compact' version, .config/gtk-4.0/gtk-dark.css to non-existent Fluent-round-Dark/gtk-4.0/gtk-dark.css.

Please fix it.

dayfuaim commented 2 years ago

Any news on this? :)