vinceliuice / Fluent-gtk-theme

Fluent design gtk theme for linux desktops
GNU General Public License v3.0
1.08k stars 61 forks source link

Incorrect hint text and cursor color in overview search box #122

Closed HymanZHAN closed 2 years ago

HymanZHAN commented 2 years ago

Thanks for your work~ Just a small visual bug report: The cursor and hint text in the overview search box seem to be of the wrong color.

Fluent shell theme:

image

Default shell theme:

Screenshot from 2022-08-28 16-22-22

Seems to me that the color of the default theme is more legible and thus "correct". I think I know where it's going wrong and can pull up a quick PR.

HymanZHAN commented 2 years ago

Ah, wrong estimation. I am not so confident that I can make changes to the source scss files without breaking something I am not aware of. I do know where in the gtk-shell.css file that is breaking the style.

/* for caret color */
#overview .search-entry {
  width: 320px;
  border: none;
  border-radius: 5px;
  /* before: caret-color: rgba(0, 0, 0, 0.75); */
  caret-color: rgba(255, 255, 255, 0.75);
  color: rgba(0, 0, 0, 0.75);
  background-color: rgba(255, 255, 255, 0.75);
  border-color: transparent;
  box-shadow: none;
  selection-background-color: #1A73E8;
  selected-color: #FFFFFF !important;
  margin-top: 12px;
  margin-bottom: 6px;
}

/* for hint text */
#overview .search-entry StLabel.hint-text {
  margin-left: 2px;
  /* before: color: rgba(0, 0, 0, 0.35); */
  color: rgba(255, 255, 255, 0.35);
}

After making the above changes to $HOME/.themes/Fluent/gnome-shell/gnome-shell.css, the issue is fixed.

image

HymanZHAN commented 2 years ago

Nonetheless, I have created a PR for your reference. Feel free to handle it as you see fit. :bow:

vinceliuice commented 2 years ago

What's your system version?

vinceliuice commented 2 years ago

Screenshot from 2022-08-28 19-12-01 This is how it looks on my desktop, did not have this issue

HymanZHAN commented 2 years ago

That's strange. I am using Fedora 36 with Gnome 42.4.

HymanZHAN commented 2 years ago

Ah, I find the culprit. The extension Blur my Shell messed up the style of overview. I will close the issue and the PR now.

HymanZHAN commented 2 years ago

LOL what a coincidence. XD Yeah I will keep my tweak local and maybe open an issue under the blur-my-shell project if it's easier to fix on their side. Thanks for looking into the issue.

vinceliuice commented 2 years ago

You are welcome