vinceliuice / Fluent-icon-theme

Fluent icon theme for linux desktops
GNU General Public License v3.0
610 stars 30 forks source link

Dark variants does not come with panel icons 深色版本似乎缺少了托盘图标 #51

Closed SteveBlackHumor closed 11 months ago

SteveBlackHumor commented 12 months ago

Describe the bug Seems like only the standard and light variants come with panel icons inside panel folder, while dark variants does not. This caused fcitx status to render improperly. 似乎只有标准版和浅色版图标包有 panel 文件夹里的托盘图标,深色版本没有。导致 fcitx 图标显示异常。

To Reproduce Steps to reproduce the behavior:

  1. Install this icon theme using ./install.sh 用 ./install.sh 安装这个图标包
  2. Install fcitx-rime 安装 fcitx-rime
  3. Switch to dark icon theme 切换到深色图标包
  4. Switch between Chinese input method and Latin input method with shift key when using rime. 用 shift 键切换 rime 自带的汉字输入法和拉丁输入法。
  5. The system tray icon on the top right corner does not change correspondingly. 右上角系统托盘并没有随之变化。
  6. Or go to installed Fluent-dark/16|22|24/ and there is no panel folder, while the same locations in Fluent-light or Fluent does have panel folder. 或者去到图标包安装路径 Fluent-dark/16或22或24/ ,里面并没有 panel 文件夹,但是 Fluent-light 或者 Fluent 下同样位置里面确实有 panel 文件夹。

Expected behavior

  1. Using dark variant, when switching between Chinese and Latin input methods, the tray icon should change correspondingly, which is what happens when using standard or light variants. 切换拉丁和汉字输入法的时候,系统托盘图标应该也会切换。标准和浅色版本确实会同步切换。
  2. I think there should be a panel folder under all of 16|22|24 folders inside dark variant. 我以为深色图标包里面无论是 16或22或24 文件夹里应该都各有一个 panel 文件夹。

Screenshots Latin Input Latin input method if behaves normally 拉丁输入法正常下的截图

Chinese Input Chinese input method if behaves normally 汉字输入法正常下的截图

Abnormal Latin Input Abnormal Latin input method 拉丁输入法异常情况下的截图

Abnormal Chinese Input Abnormal Chinese input method 汉字输入法异常情况下的截图

Normal Folder Structure Normal folder structure with panel folder 正常的有 panel 文件夹的文件结构

Abnormal Folder Structure Abnormal folder structure without panel folder 异常的没有 panel 文件夹的文件结构

Desktop

Additional context I don't know much about .sh coding, but seems like with -light, line 85-94 of install.sh does either reverse the colors or copy the files in "panel" folder. However, when -dark option is selected, seems like all folders except "panel" are processed. 不是很懂 .sh 代码,但是我看了 install.sh 85-94 行 -light 选项的时候 panel 文件夹里的文件有被复制然后转色。但是到 -dark 选项的时候,从 134-154 行几乎所有文件夹都会被处理,但是好像就是没有 panel 文件夹有关的代码。

The comment in line 89 confuses me, does it say line 90-94 are processing panel folder for dark variant of this icon theme? 如果我没理解错第 89 行注释,第 90-94 行代码是在处理深色图标包里 panel 文件夹?