Theme breaks completely when using "color-scheme prefer-dark"

vinceliuice / Layan-gtk-theme

Layan-gtk-theme

GNU General Public License v3.0

546 stars 48 forks source link

Theme breaks completely when using "color-scheme prefer-dark" #51

Open Arcitec opened 2 years ago

Arcitec commented 2 years ago

Hello, I am on the latest GIT code.

The theme becomes completely non-styled if "prefer-dark" is activated.

I am using Layan-Dark-Solid. But it seems to happen with all Layan themes.

# Break theme completely.
gsettings set org.gnome.desktop.interface color-scheme prefer-dark

# Fix theme.
gsettings set org.gnome.desktop.interface color-scheme default

PS: I have copied the Layan-Dark-Solid/gtk-4.0 folder's contents to ~/.config/gtk-4.0/ and it does a decent job styling GTK-4/LibAdwaita applications. Great job! (This folder has nothing to do with the bug, I just wanted to thank you for having a semi-working GTK-4 already. :))

Arcitec commented 2 years ago

Forgot to say: This is a very important bug, because the "color-scheme" property is used by a TON of modern applications to determine some things:

What color scheme to use for things like internal syntax highlighting (backgrounds, text colors). To avoid getting black text on dark theme background.
It is used to hint what colors to use in totally non-GTK applications from other environments such as Qt.

SeineEloquenz commented 1 year ago

While more a crude band aid fix than a real solution, I could work around the problem for now by setting the GTK_THEME=Layan-Dark environment variable explicitly globally. Haven't noticed any major issues with this except some styling breaking in gnome-control-center (which I don't use much anyway) and obviously the light/dark-theme toggle breaking.

Aurillium commented 1 year ago

I've also experienced this issue and the workaround makes my desktop environment break (not a clue why, but it means it's not feasible to use; I'd have to add it to the app's desktop entry and that's not really accessible for most users).