search

vinceliuice / MacSonoma-kde

MacOS Sonoma theme for KDE Plasma
GNU Lesser General Public License v3.0
104 stars 2 forks source link

Add a AUR package #5

Open Fosssil opened 1 year ago

Fosssil commented 1 year ago

Can you please provide a AUR package. If not, can I pull request for it ? Please let us know

vinceliuice commented 1 year ago

I don't know how to make AUR package, if you can pull request for it that would be great !

Fosssil commented 1 year ago

I don't know how to make AUR package, if you can pull request for it that would be great !

Okay, no problem I will work on it

D3vil0p3r commented 11 months ago

For AUR package usually the installation is done at system-level (so, for all users), while install.sh installs elements only on the current user directories.

@vinceliuice can you implement please in install.sh also an argument where we can define the destination path? It can be useful for AUR package to install for all users.

vinceliuice commented 11 months ago

No problem!

D3vil0p3r commented 11 months ago

No problem!

Thank you for the commit. There is just one issue: usually, when it is needed to create a package, it is built in an "isolated/fake environment" that usually is specified by a variable named $pkgdir that corresponds to a fake root directory where the building system goes to put all the files there before to pack the package. If the building system tries to copy the source files (for example your repo files) directly on /usr or any other dir, it gets Permission Denied (because the building system can act only on its fakeroot environment to create the final pkg).

This is the reason it is needed to implement a specific argument to specify the rootdir. In this manner, the building system can run a command like ./install.sh -p $pkgdir and it will know that all the source files must be copied in the fakeroot directory $pkgdir/usr.

I think that a good solution could be the creation of a Makefile because it already has an option to install files in a chosen target dir.

D3vil0p3r commented 11 months ago

In practice, you must use the same --dest argument approach you used in this your install.sh file of WhiteSur-gtk-theme repo.

vinceliuice commented 11 months ago

No problem

D3vil0p3r commented 11 months ago

Thank you @vinceliuice . @Fosssil I created the package in AUR: https://aur.archlinux.org/packages/macsonoma-kde-theme-git

Also requested packaging by Chaotic AUR: https://github.com/chaotic-aur/packages/issues/2869

AlphaJack commented 7 months ago

The package has been renamed to https://aur.archlinux.org/packages/plasma5-themes-macsonoma-git