search

vinceliuice / Matcha-gtk-theme

Matcha is a flat Design theme for GTK 3, GTK 2 and Gnome-Shell
https://www.pling.com/p/1187179/
GNU General Public License v3.0
743 stars 67 forks source link

GTK4 support #154

Closed alex-tee closed 3 years ago

alex-tee commented 3 years ago

Hi, I was wondering if you would consider GTK4 support since it's out already and apps will start using it (I suppose many GNOME apps will be first)

I currently don't see it available in the inspector in gtk4-demo Screenshot from 2021-03-21 03-17-31

codic12 commented 3 years ago

https://github.com/vinceliuice/Matcha-gtk-theme/commit/5b6193d639e4eec061bbd3c038c4447110313a06 seems to be done, yay!

alex-tee commented 3 years ago

nice!

Screenshot from 2021-04-08 22-27-05

It looks to be working besides some warnings:


(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.098: Theme parsing error: gtk.css:1059:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.099: Theme parsing error: gtk.css:2227:3-26: No property named "-GtkArrow-arrow-scaling"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.100: Theme parsing error: gtk.css:3621:3-37: No property named "-GtkScrollbar-has-backward-stepper"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.100: Theme parsing error: gtk.css:3622:3-36: No property named "-GtkScrollbar-has-forward-stepper"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4172:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4427:14-18: negative values are not allowed.

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4491:21-35: Not a valid image

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4501:21-35: Not a valid image

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4511:21-35: Not a valid image

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.101: Theme parsing error: gtk.css:4521:21-35: Not a valid image

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.102: Theme parsing error: gtk.css:5222:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.103: Theme parsing error: gtk.css:6439:3-26: No property named "-PnlDockBin-handle-size"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:6483:3-26: No property named "-PnlDockBin-handle-size"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:6599:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:6826:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:6930:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:7203:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:7462:3-41: No property named "-NemoPlacesTreeView-disk-full-bg-color"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.104: Theme parsing error: gtk.css:7463:3-41: No property named "-NemoPlacesTreeView-disk-full-fg-color"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:7957:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:7969:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8024:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8041:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8090:3-27: No property named "-UnityDecoration-extents"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8091:3-33: No property named "-UnityDecoration-input-extents"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8092:3-35: No property named "-UnityDecoration-shadow-offset-x"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8093:3-35: No property named "-UnityDecoration-shadow-offset-y"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8094:3-39: No property named "-UnityDecoration-active-shadow-color"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8095:3-40: No property named "-UnityDecoration-active-shadow-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8096:3-41: No property named "-UnityDecoration-inactive-shadow-color"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8097:3-42: No property named "-UnityDecoration-inactive-shadow-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8098:3-29: No property named "-UnityDecoration-glow-size"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8099:3-30: No property named "-UnityDecoration-glow-color"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8100:3-32: No property named "-UnityDecoration-title-indent"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8101:3-30: No property named "-UnityDecoration-title-fade"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8102:3-35: No property named "-UnityDecoration-title-alignment"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.105: Theme parsing error: gtk.css:8304:3-29: No property named "-NaTrayApplet-icon-padding"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8305:3-26: No property named "-NaTrayApplet-icon-size"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8355:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8434:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8493:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8530:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:8656:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:9179:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:9191:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:9202:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.106: Theme parsing error: gtk.css:9335:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.107: Theme parsing error: gtk.css:9404:3-22: No property named "-gtk-outline-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10125:3-19: No property named "-gtk-icon-effect"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10815:3-36: No property named "-GtkTreeView-horizontal-separator"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10816:3-34: No property named "-GtkTreeView-vertical-separator"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10874:3-29: No property named "-GtkTreeView-expander-size"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10907:3-37: No property named "-GraniteWidgetsPopOver-arrow-width"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10908:3-38: No property named "-GraniteWidgetsPopOver-arrow-height"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10909:3-39: No property named "-GraniteWidgetsPopOver-border-radius"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10910:3-38: No property named "-GraniteWidgetsPopOver-border-width"

(gtk4-demo:245086): Gtk-WARNING **: 22:26:15.108: Theme parsing error: gtk.css:10911:3-37: No property named "-GraniteWidgetsPopOver-shadow-size"
codic12 commented 3 years ago

Looks like some CSS was copied from gtk3 that is no longer relevant to gtk4.

vinceliuice commented 3 years ago

You are right, I'll remove that

vinceliuice commented 3 years ago

Fixed!