search

vinceliuice / McMojave-circle

McMojave-circle icon theme for linux desktops
GNU General Public License v3.0
393 stars 43 forks source link

Some status icons don't change #10

Closed P1zz4br0etch3n closed 4 years ago

P1zz4br0etch3n commented 4 years ago

Expected behaviour:

  1. Open Gnome Tweak Tool
  2. Change Icon theme to 'McMojave-circle-blue-dark'
  3. All icons change including status icons

Current behaviour:

  1. Open Gnome Tweak Tool
  2. Change Icon theme to 'McMojave-circle-blue-dark'
  3. All icons change except some status icons (battery, audio-volume, system-shutdown)

System:

vinceliuice commented 4 years ago

Can you give a screenshot

P1zz4br0etch3n commented 4 years ago

Sure.

First a screenshot with the Numix-Circle theme: Bildschirmfoto vom 2019-09-16 17-43-47

And then after changing to McMojave-circle-blue-dark: Bildschirmfoto vom 2019-09-16 17-43-59

As you can see, the network status icon changes, but audio and battery stay the same. This started happening a few days ago, probably with an older version of the icon theme. I updated to the latest version but it's still there.

vinceliuice commented 4 years ago

You can download and reinstall it from github, maybe reboot your desktop again

P1zz4br0etch3n commented 4 years ago

I downloaded the release from github, installed it with the install.sh and rebooted, but the issue is still there.

Also the thumbnails of these icons, e.g. in the status/16 folder, aren't created well in nautilus. Bluetooth works and the icons change in the panel menu, but battery doesn't work. I think it's maybe related to how the svg files are saved? Though I don't have any problems opening the files in Incskape/Gimp/LibreOffice Draw.

Bildschirmfoto vom 2019-09-17 11-08-39

Am I the only one facing this issue?

P1zz4br0etch3n commented 4 years ago

I was able to reproduce this bug in a VM. Just grab a Fedora 30 image, install it in a VM, install the icon-theme and then do a dnf update. After a reboot some icons are just gone. If one changes the icon theme to something else and back, the icons from the other theme will stay.

vinceliuice commented 4 years ago

Did you install this theme with sudo, and after you do dnf update then icon theme just gone?

vinceliuice commented 4 years ago

There must be something issue on your system, because you are the only one report this issue, and everything works well on my desktop

P1zz4br0etch3n commented 4 years ago

Did you install this theme with sudo, and after you do dnf update then icon theme just gone?

On my local machine I moved the folders to /usr/share/icons with sudo. But I did it multiple times again since the update and nothing changes. In the VM I just copied them to ~/.icons and there it's the same. One of the updated libraries is librsvg2 but downgrading it doesn't help. Though I think it's something related to how my system renders SVGs.

There must be something issue on your system, because you are the only one report this issue, and everything works well on my desktop

But it's also in the VM, where I didn't configure anything else. So maybe it's only on Fedora. Which distro are you using?

vinceliuice commented 4 years ago

You can install this theme without use sudo, just install it on your user folder, maybe Fedora firewall software delete all files not safety （ not installed from system software manager ）

P1zz4br0etch3n commented 4 years ago

I know, but I want it to be available for multiple users. And as I mentioned, in the VM I installed it in the user folder, but after updating it's the same issue. The files are all there, they're just not rendered correctly. Maybe it's how you created the SVGs. I read here that not every svg renderer supports every feature. Maybe you used a new feature for some of your icons which aren't supported by the renderer in Fedora. Did you use something different e.g. for battery (not working) compared to network (working) status?

Thanks for your quick replies btw!

vinceliuice commented 4 years ago

Only battery icons have this issue on fedora?

vinceliuice commented 4 years ago

I used ubuntu and inkscape to make them

vinceliuice commented 4 years ago

Are you using last version of Fedora? maybe I can download one to check this issue

P1zz4br0etch3n commented 4 years ago

Only battery icons have this issue on fedora?

The ones I am missing are audio-volume and battery, which should be in the empty space here (top right corner of the screen):

Bildschirmfoto vom 2019-09-19 09-45-01

Also in the menu battery is missing and the shutdown button is too big:

Bildschirmfoto vom 2019-09-19 09-50-23

And in the places menu the icon for my computer is missing:

Bildschirmfoto vom 2019-09-19 09-55-22

I used ubuntu and inkscape to make them

The guy on reddit also used Inkscape, maybe it's a similar issue. Weird though that it's only on Fedora.

Are you using last version of Fedora? maybe I can download one to check this issue

Yes, Fedora 30 is currently the latest version.

vinceliuice commented 4 years ago

Ok! I will install Fedora 30 to test my theme

P1zz4br0etch3n commented 4 years ago

Thank you so much!

bruno-anjos commented 4 years ago

I have the exact same problem in Fedora 30. Just wanted to let you know it is not only affecting you. error1 error2

My fedora version is up to date btw.

gbegkas commented 4 years ago

Hi, I also have the same issue in Arch with Gnome 3.32.2, so it's not a Fedora only problem. I am missing the battery and shutdown icons. It happened recently after a system update (in the last 2 weeks) without updating the icon theme.

vinceliuice commented 4 years ago

I'll fix this

P1zz4br0etch3n commented 4 years ago

I noticed that a fully up to date Ubuntu 19.04 has an older version of librsvg2 than Fedora. Ubuntu has version 2.44.10 On Fedora it's: 2.45.90 Can you please all check which version you have installed? I bet it's related to a change in the lib.

bruno-anjos commented 4 years ago

My librsvg2 version is 2.45.90-1

gbegkas commented 4 years ago

I have installed 2.46.0 and I downgraded it to 2.44.10 but the issue remains.

vinceliuice commented 4 years ago

Can you try tela or other icon theme, I want to know the reason of this issue is icon missing or icon file problem

vinceliuice commented 4 years ago

Did you install the last version of github? that's my fedora: 2019-09-21 08-15-31 的屏幕截图

vinceliuice commented 4 years ago

I don't have this issue, I don't konw why?

vinceliuice commented 4 years ago

Sorry my fault! I foget to upload my last version into github

vinceliuice commented 4 years ago

Now you can downlad the last version I upload here!

P1zz4br0etch3n commented 4 years ago

Can you try tela or other icon theme, I want to know the reason of this issue is icon missing or icon file problem

Tela works fine for me.

Did you install the last version of github? that's my fedora:

You installed Fedora 31. I'm on 30, which is the latest stable release. But this means there is hope it will just work on a later release.

Now you can downlad the last version I upload here!

I downloaded the latest version (master branch) but the issue is still there for me.

vinceliuice commented 4 years ago

So only fedora 30 have this issue, OK, I'll fedora 30 to test this

gbegkas commented 4 years ago

Can you try tela or other icon theme, I want to know the reason of this issue is icon missing or icon file problem

With Tela icons that didn't work with McMojave are there but I am not so sure that they are the correct icons (I think they are the fallback ones)

1

However on my laptop The wifi icon on the dropdown menu is missing as shown in the picture bellow

2

Now you can downlad the last version I upload here!

The latest version didn't fix the issue for me too

vinceliuice commented 4 years ago

As I know, Gnome 3.34 have changed some icons name, so some icons like battery icons if missing will show the default icon theme

vinceliuice commented 4 years ago

2019-09-22 15-49-30 的屏幕截图

vinceliuice commented 4 years ago

Also have no issues on fedora 30, Maybe you can download the last version on github (master zip not release file) and reinstall this theme

P1zz4br0etch3n commented 4 years ago

Did you do a dnf update --refresh? With a fresh install I'm not having this issue neither. Only after updating all packages. And I already tried the master zip with no luck.

vinceliuice commented 4 years ago

DId not update it, I'll try this

vinceliuice commented 4 years ago

Fedora 31 beta works well and Fedora works well, I think there must be something issue about librsvg2 update and Fedora 31 fix it

P1zz4br0etch3n commented 4 years ago

Fedora 31 beta works well and Fedora works well, I think there must be something issue about librsvg2 update and Fedora 31 fix it

No, I don't think so, because @gbegkas downgraded to the same version like you have on Ubuntu and still has the issue. And even with the newer version 2.46.0 he had the issue. It must be something else.

Fedora 31 beta works well and Fedora works well, I think there must be something issue about librsvg2 update and Fedora 31 fix it

So you updated your Fedora 30 and still don't see the issue?

vinceliuice commented 4 years ago

I'll update my Fedora and test this issue

vinceliuice commented 4 years ago

I update my Fedora 30 and find out that Fadora can not preview svg files if it has title, so I removed all svg titles as all as I can find to fix this, Now I upload the fixed one on github, you can try it

P1zz4br0etch3n commented 4 years ago

Yes! That resolved the issue. Thank you very much!

vinceliuice commented 4 years ago

That's all right!