search

vinceliuice / McMojave-circle

McMojave-circle icon theme for linux desktops
GNU General Public License v3.0
389 stars 43 forks source link

The Inherits value is not really good #26

Closed trmdi closed 4 years ago

trmdi commented 4 years ago

For example, in KDE, a common usecase is the user only installs this icon theme, not Numix-Circle-Light,Adwaita. So when running a GUI app from terminal it will show lots of warning like this:

▶ dolphin 
Icon theme "Numix-Circle-Light" not found.
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/8x8/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/16x16/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/16x16/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/22x22/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/24x24/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/24x24/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/32x32/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/32x32/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/48x48/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/48x48/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/256x256/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/512x512/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/scalable/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/scalable/ui/"

Can we modify the installation script to set Inherits=breeze,hicolor for KDE users?

vinceliuice commented 4 years ago

No problem!

P1zz4br0etch3n commented 4 years ago

@trmdi Have you tried Numix-Circle-Light? I think it fits pretty good as fallback for this icon theme. Better than default system icons.

vinceliuice commented 4 years ago

I updated the install.sh, now different Inherits will be added according to different desktop environments.