search

vinceliuice / McMojave-circle

McMojave-circle icon theme for linux desktops
GNU General Public License v3.0
389 stars 43 forks source link

Battery Icon is hard to read on dark background #27

Closed rapiz1 closed 4 years ago

rapiz1 commented 4 years ago

Description

The battery icon is hard to read on some dark plasma themes.

image With cursor hovering: image

It should be battery-100 image

The icon is hard to read on both dark and light background.

Environment

DE: KDE Plasma Theme: Materia Blur Mono (also confirmed in Breeze Dark, Arc Dark) Icon Theme: McMojave-circle-blue-dark

vinceliuice commented 4 years ago

What is this plugin? it's not plasma default battery plugin

rapiz1 commented 4 years ago

solaar

rapiz1 commented 4 years ago

Maybe it's related to my color scheme? I use Materia Light.

vinceliuice commented 4 years ago

你中国的吗，我看到这个是罗技鼠标的软件

rapiz1 commented 4 years ago

是啊 我看这个图标确实来自mcmojave

vinceliuice commented 4 years ago

那用汉语交流吧，哈哈，我济南的

vinceliuice commented 4 years ago

应该是图标主题的事

vinceliuice commented 4 years ago

只是我还不确定是使用的哪个图标

vinceliuice commented 4 years ago

我安装了一下这个软件，但是我没有罗技鼠标，所以不显示电池图标

vinceliuice commented 4 years ago

其他的图标主题也有这个问题吗？

rapiz1 commented 4 years ago

Papirus-Dark, Breeze都没有这个问题

rapiz1 commented 4 years ago

https://github.com/pwr-Solaar/Solaar/blob/2a94cc9233d000bab8d9864631dd23fcb81137bd/lib/solaar/ui/icons.py#L95-L101 这些是图标选择逻辑 我正在看

vinceliuice commented 4 years ago

好的，我对比一下Papirus-Dark的图标，看怎么修复，我看显示的那个图标是短一些的电池图标，应该是battery-full-symbolic.svg这种后面带symbolic的图标，应该这是给gnome桌面使用的图标只能是16x16的尺寸的，所以短一些，而不带symbolic的图标是正常长度的

rapiz1 commented 4 years ago

对的。我刚刚通过调试源码发现使用的是battery-full-symbolic

vinceliuice commented 4 years ago

嗯，知道什么图标了就好办，我再看看Papirus怎么处理的就知道怎么修复了

vinceliuice commented 4 years ago

我更新了一下，你试试最新的

rapiz1 commented 4 years ago

image 解决了，谢谢！很快，很厉害！

vinceliuice commented 4 years ago

不客气