vinceliuice / Mojave-gtk-theme

Mojave is a macos Mojave like theme for GTK 3, GTK 2 and Gnome-Shell
GNU General Public License v3.0
1.5k stars 242 forks source link

No Shadows around window #59

Open dr3mro opened 5 years ago

dr3mro commented 5 years ago

I am using arch linux with latest variant of your marvelous theme from git using aur build system but I noticed only your theme has disabled shadows around windows and getting error in systemd journal about shadow error so can you please fix these errors and enable shadows around windows or at least create a shadow enabled iteration of your theme thank you for your hard work

Oct 09 14:11:25 x250 gnome-shell[5249]: loading user theme: /usr/share/themes/Mojave-dark-solid-alt/gnome-shell/gnome-shell.css
Oct 09 14:11:25 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:11:25 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:11:25 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:11:25 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:25 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:11:40 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:11:40 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:17 x250 gnome-shell[5249]: Attempting load of libEGL.so
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:12:50 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:13:53 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:13:53 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:13:57 x250 gnome-shell[5249]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: loading user theme: /usr/share/themes/Mojave-dark/gnome-shell/gnome-shell.css
Oct 09 14:14:21 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:14:21 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:14:21 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:14:21 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:21 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:559:1: Expected a valid selector
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1148:2: Expected semicolon
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1489:27: Expected a valid selector
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1618:15: 'bborder-color' is not a valid property name
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1618:15: 'bborder-color' is not a valid property name
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1622:20: Expected a valid selector
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1988:15: 'bborder-color' is not a valid property name
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:4363:2: Expected semicolon
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:4994:2: Junk at end of value for border-radius
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:6305:26: Expected a valid selector
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:7321:26: Expected a valid selector
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8201:64: Junk at end of value for background-image
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8820:55: Using one color stop with linear-gradient() is deprecated.
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8820:55: Missing closing bracket at end of linear gradient
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8933:19: not a number
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8951:15: 'bcbcbc' is not a valid color name
Oct 09 14:14:28 x250 gnome-shell[5249]: Theme parsing error: gtk.css:10394:20: Not a valid image
Oct 09 14:14:28 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:28.998: Theme parsing error: gtk.css:559:1: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:559:1: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1148:2: Expected semicolon
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1489:27: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1618:15: 'bborder-color' is not a valid property name
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1622:20: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.008: Theme parsing error: gtk.css:1148:2: Expected semicolon
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:1988:15: 'bborder-color' is not a valid property name
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:4363:2: Expected semicolon
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:4994:2: Junk at end of value for border-radius
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.019: Theme parsing error: gtk.css:1489:27: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.019: Theme parsing error: gtk.css:1618:15: 'bborder-color' is not a valid >
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.020: Theme parsing error: gtk.css:1622:20: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:6305:26: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:7321:26: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8201:64: Junk at end of value for background-image
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8820:55: Using one color stop with linear-gradient() is deprecated.
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8820:55: Missing closing bracket at end of linear gradient
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8933:19: not a number
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:8951:15: 'bcbcbc' is not a valid color name
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.029: Theme parsing error: gtk.css:1988:15: 'bborder-color' is not a valid >
Oct 09 14:14:29 x250 gnome-shell[5249]: Theme parsing error: gtk.css:10394:20: Not a valid image
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.065: Theme parsing error: gtk.css:4363:2: Expected semicolon
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.071: Theme parsing error: gtk.css:4994:2: Junk at end of value for border->
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.082: Theme parsing error: gtk.css:6305:26: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.092: Theme parsing error: gtk.css:7321:26: Expected a valid selector
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.096: Theme parsing error: gtk.css:8201:64: Junk at end of value for backgr>
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.098: Theme parsing error: gtk.css:8820:55: Using one color stop with linea>
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.099: Theme parsing error: gtk.css:8820:55: Missing closing bracket at end >
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.101: Theme parsing error: gtk.css:8933:19: not a number
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.102: Theme parsing error: gtk.css:8951:15: 'bcbcbc' is not a valid color n>
Oct 09 14:14:29 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:14:29.108: Theme parsing error: gtk.css:10394:20: Not a valid image
Oct 09 14:14:58 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:14:58 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:16:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:16 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:16 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:26 x250 gnome-shell[5249]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: loading user theme: /usr/share/themes/Mojave-dark-solid-alt/gnome-shell/gnome-shell.css
Oct 09 14:17:39 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:39 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:39 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:39 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:39 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:43 x250 gnome-shell[5249]: libinput error: client bug: timer event5 debounce short: offset negative (-3ms)
Oct 09 14:17:58 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:17:58 x250 gnome-shell[5249]: setup_framebuffers: assertion 'width > 0' failed
Oct 09 14:18:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:18:06 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:18:17 x250 gnome-shell[5249]: libinput error: client bug: timer event5 debounce short: offset negative (-1ms)
Oct 09 14:18:50 x250 gnome-shell[5249]: libinput error: client bug: timer event5 debounce: offset negative (-88ms)
Oct 09 14:18:50 x250 gnome-shell[5249]: libinput error: client bug: timer event5 debounce short: offset negative (-101ms)
Oct 09 14:18:51 x250 gnome-shell[5249]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Oct 09 14:19:32 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:19:32 x250 gnome-shell[5249]: Ignoring excess values in shadow definition
Oct 09 14:19:36 x250 gnome-shell[5249]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Oct 09 14:20:09 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:20:09.434: Theme parsing error: gtk.css:559:1: Expected a valid selector
Oct 09 14:20:09 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:20:09.437: Theme parsing error: gtk.css:1148:2: Expected semicolon
Oct 09 14:20:09 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:20:09.440: Theme parsing error: gtk.css:1489:27: Expected a valid selector
Oct 09 14:20:09 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:20:09.441: Theme parsing error: gtk.css:1618:15: 'bborder-color' is not a valid >
Oct 09 14:20:09 x250 gnome-shell[5249]: (/usr/lib/firefox/firefox:23949): Gtk-WARNING **: 14:20:09.441: Theme parsing error: gtk.css:1622:20: Expected a valid selector
lines 179-221
vinceliuice commented 5 years ago

Could you download from github and try again, because the version from AUR is not uploaded by me, so I don't know if it is the last version.

dr3mro commented 5 years ago

I can confirm it happens with latest updated version from git I had to override your theme with .config/gtk-3.0/gtk.css window,decoration,decoration:backdrop { box-shadow: 5px 5px 12px 0 rgba(0, 0, 0, 0.3), 5px 5px 12px 0 rgba(0, 0, 0, 0.2); }

to make it work for me but this hack is not as if the theme is updated

vinceliuice commented 5 years ago

I can confirm there is box-shadow under decoration : 2019-10-09 23-43-58 的屏幕截图

vinceliuice commented 5 years ago

It works well on my Gnome, can you give me a screenshot if you don't have shadow under app window

dr3mro commented 5 years ago

Screenshot from 2019-10-10 00-20-53 Screenshot from 2019-10-10 00-21-43 here is a screenshot using the gtk.css hack and without the hack

dr3mro commented 5 years ago

here is the package build script using aur as you can see it builds the latest version from git using gnome 3.34.1 arch linux with all updates

`#Maintainer Robosky fangyuhao0612@gmail.com pkgname=mojave-gtk-theme-git _pkgname=Mojave-gtk-theme pkgver=244.d955b51 pkgrel=1 pkgdesc='A Mac OSX like theme for GTK 3, GTK 2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments like Gnome, Pantheon, XFCE, Mate, etc.' arch=('any') depends=('gtk3' 'gtk-engine-murrine' 'gtk-engines') license=('GPL3') url='https://github.com/vinceliuice/Mojave-gtk-theme' source=('git+https://github.com/vinceliuice/Mojave-gtk-theme.git') md5sums=('SKIP') makedepends=('git') options=('!strip')

pkgver() { cd "${srcdir}/${_pkgname}" echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) }

package() { cd "${srcdir}/${_pkgname}" install -m755 -d "${pkgdir}/usr/share/themes" ./install.sh \ --dest "${pkgdir}/usr/share/themes" \ --icon arch }`

vinceliuice commented 5 years ago

I got this, the dark version windows shadow is not obvious

vinceliuice commented 5 years ago

I'll fix this

dr3mro commented 5 years ago

Fixed with last commit and I aur package reached my system by update and works fine thanks fir your hard work