search

vinceliuice / Mojave-gtk-theme

Mojave is a macos Mojave like theme for GTK 3, GTK 2 and Gnome-Shell
GNU General Public License v3.0
1.48k stars 241 forks source link

Electron Menubar Needs Gradient #70

Open berkiyo opened 4 years ago

berkiyo commented 4 years ago

Hi Vince,

Firstly, your theme is amazing. Not only does it look the part, it also is very readable and makes for an excellent alternative to Adwaita.

I have one minor issue that bothers me somewhat and that is the lack of gradient in Electron menubars.

Below is a screenshot of an electron menubar, the program used is Typora. Electron Legacy Menubar

Here is what it should like (GTK+ Menubar), the program used is Evolution. GTK Legacy Menubar

If you do add the gradient, be sure to have a little separation between menubar and main window content like in the screenshot above - it really helps with readability. If you could fix this, it would be much appreciated!

All the best!

vinceliuice commented 4 years ago

I want to but electron menubar does not support this, electron based on chromium so electron app use chromium menubar we can not make it look like the gtk menubar, just like we can not change the style of chrome menubar

berkiyo commented 4 years ago

I see, fair enough. I thought it would be a simple fix as Qogir-Light looks fine but then again, all the elements are white in that theme. All good then! :)