vinceliuice / Orchis-theme

Orchis is a [Material Design](https://material.io) theme for GNOME/GTK based desktop environments.
GNU General Public License v3.0
2.79k stars 213 forks source link

Apps use hardcoded adwaita instead of Orchis #187

Closed sheeepdev closed 2 years ago

sheeepdev commented 2 years ago

Hey, first I wanna say that I love this theme and use it every day :) Thank you for maintaining it.

I have a few problems, since a lot of gnome apps have recently been switching to GTK4, the themes and icons (the icons that im using are Tela-circle) aren't working, so I have to downgrade to an older version for the apps to be able to work.

Trying to switch the theme with the GTK inspector doesn't work either, it seems they are broken.

The only thing im not sure about is if this was fixed in a recent update. My theme is from november so maybe you did some updates in between? Nope. Reinstalled (updated) theme. Still the same.

Here is a example (app is fragments torrent client):

image

GZGavinZhao commented 2 years ago

Fragments is intentional: https://stopthemingmy.app/ Felix Häcker signed his name at the bottom.

sheeepdev commented 2 years ago

Fragments is intentional: stopthemingmy.app Felix Häcker signed his name at the bottom.

So there is no way to theme it?

sheeepdev commented 2 years ago

https://github.com/do-not-theme/do-not-theme.github.io/issues/3

https://github.com/do-not-theme/do-not-theme.github.io/issues/8

These issues may solve some stuff...

GZGavinZhao commented 2 years ago

Yes, you cannot theme it, at least not using a theme. I do not think there is anything @vinceliuice can do in this case.

MolassesLover commented 2 years ago

I've written a lot of GTK 4 applications and I can confirm Orchis works. I think you should close this issue

sheeepdev commented 2 years ago

@MolassesLover Then this is probably a issue with hardcoding Adwaita, not GTK4? (mostly people who signed dont theme our apps)

MolassesLover commented 2 years ago

@sheeepdev It's definitely caused by hardcoding Adwaita into the application. GTK 4 vanilla doesn't do that, so the developer went out of their way to force Adwaita. I hope that helps. If you want I can look into the Fragments source code to alter it, but that might take a little while

sheeepdev commented 2 years ago

@sheeepdev It's definitely caused by hardcoding Adwaita into the application. GTK 4 vanilla doesn't do that, so the developer went out of their way to force Adwaita. I hope that helps. If you want I can look into the Fragments source code to alter it, but that might take a little while

That would be amazing if you could do that, because currently I needed to downgrade and miss new features.

sheeepdev commented 2 years ago

Anyways, this isnt a problem with Orchis but rather app developers hardcoding adwaita, so im gonna close this issue

MolassesLover commented 2 years ago

@sheeepdev It's definitely caused by hardcoding Adwaita into the application. GTK 4 vanilla doesn't do that, so the developer went out of their way to force Adwaita. I hope that helps. If you want I can look into the Fragments source code to alter it, but that might take a little while

That would be amazing if you could do that, because currently I needed to downgrade and miss new features.

Yeah, I'll take a look at it later today. Sorry if takes a little while, though, I'm also working on Tela Circle. I love GTK theming and anyone that forces Adwaita onto somebody else is insane lawl

vinceliuice commented 2 years ago

If gtk4 app use libadwaita then it can not use 3rd themes

Thesola10 commented 2 years ago

libadwaita apps do appear to listen to $GTK_THEME, and forcing Orchis onto one causes a few graphical issues, mostly with lists being unthemed and ex-libhandy components having incorrect margins.

image

image

MolassesLover commented 2 years ago

I'm working on a version of Libadwaita that uses Orchis, rather than Adwaita

Thesola10 commented 2 years ago

@MolassesLover is this really the right approach? If I understand correctly, that would imply multiplying versions of libadwaita for every Gtk theme?

MolassesLover commented 2 years ago

It would multiply the versions yeah. I found a better solution, though, which is a lot more streamlined. I'll look into finishing it sometime, but no guarantees, I personally don't use Orchis anymore.

MolassesLover commented 2 years ago

Nevermind, Vince beat me to it!

Thesola10 commented 2 years ago

Well, the new Gtk4 theme (at least on my install on Arch) is systematically dark with a grey accent. Is there a gsettings key that needs to be changed? (cf. #199)