search

vinceliuice / Orchis-theme

Orchis is a [Material Design](https://material.io) theme for GNOME/GTK based desktop environments.
GNU General Public License v3.0
2.79k stars 213 forks source link

All Gtk4 variants are dark grey #199

Closed Thesola10 closed 2 years ago

Thesola10 commented 2 years ago

This is a regression introduced somewhere in April, likely in fixing #187, which causes all Gtk4 apps to display a dark variant of the theme with a grey accent colour, regardless of the theme variant used, or whether they use libadwaita or not.

Better commit messages would help bisect the issue.

Thesola10 commented 2 years ago

This is a screenshot of an affected app, Widget Factory, using Orchis-Yellow-Light-Compact. image

This is a screenshot of the Gtk3 widget factory, using the exact same theme. image

vinceliuice commented 2 years ago

Gtk 4.0 apps whitch use libadwaita will not support theme follow the tweaks setting, so I just link a dark version of default theme to $HOME/.config/gtk-4.0 to make all gtk 4.0 app use this theme, so if you want to change the gtk 4.0 app theme you need to re-link the theme you want to use by run the install.sh again, for example you want to use: Orchis-Yellow-Light, then you can run ./install.sh -t yellow -c light

Thesola10 commented 2 years ago

Given that this behaviour retroactively breaks all Gtk4 apps, may I suggest that this tweak be configurable as a flag in the ./install.sh script? Something like a --libadwaita flag

Thesola10 commented 2 years ago

Also, your tweak appears to be broken, as when I install -t yellow -c light -s compact, the theme that gets linked is Orchis-Yellow-Compact, not Orchis-Yellow-Light-Compact.

vinceliuice commented 2 years ago

About the install.sh issue It's fixed now

vinceliuice commented 2 years ago

And I'll add this as a option

vinceliuice commented 2 years ago

Fixed!