vinceliuice / Qogir-theme

Qogir is a flat Design theme for GTK
GNU General Public License v3.0
1.55k stars 118 forks source link

Close window via click on the very top right corner #4

Open ghost opened 6 years ago

ghost commented 6 years ago

Using gnome-session-flashback, maximized windows have the close button at the very top right corner of the screen.

As stated in the title, I would like to be able to close a window by clicking on this very top right corner. Unfortunately, this does not work consistently, sometimes it works (and the "X" has a red hover effect), sometimes it does not.

If you position the cursor at the top right corner of the screen and move the mouse again in the top right direction, the hover effect and, accordingly, the close effect changes randomly.

grigorii-horos commented 5 years ago

I have the same issue in KDE

output

ww-9 commented 4 years ago

48b2abb2d73e

It works correctly in Gnome Files, but in GNOME Terminal, gedit or Firefox not. Is it theme or GTK issue?

ww-9 commented 4 years ago

headerbar entry, headerbar spinbutton, headerbar button, headerbar separator { margin-top: 0; margin-bottom: 2px; }

this code seems to fix the issue

Hasshu commented 2 years ago

See also https://gitlab.gnome.org/GNOME/gtk/-/issues/583

evgeniy-harchenko commented 1 year ago

Have a similar problem on most windows. The part of close button near screen edge is not working. When I click on this part it clicks through the window, so current window loses focus, or it can close the window behind it. There is no problem on all apps in flatpak (also using this theme), Pamac, Google Chrome (Chromium). But the theme looks a bit different on them: buttons are bigger, header bar is wider, close button on hover is faded red (not red like on others).

I use XFCE+Compiz. There is no problem on XFCE+XFWM. Tested on Manjaro and EndeavourOS.

Also there is no problem on Arc theme (on which this theme is based) and Matcha themes, which also based on Arc.

111

UPD: Ok, here is a solution: Find metacity-theme-3.xml in your theme and replace this:

<frame_geometry name="max" title_scale="medium" parent="normal" rounded_top_left="false" rounded_top_right="false">
    <distance name="left_width" value="0" />
    <distance name="right_width" value="0" />
    <distance name="bottom_height" value="0" />
</frame_geometry>

with this:

<frame_geometry name="max" title_scale="medium" parent="normal" rounded_top_left="false" rounded_top_right="false">
    <distance name="left_width" value="1" />
    <distance name="right_width" value="1" />
    <distance name="bottom_height" value="0" />
</frame_geometry>

Since this fix is ​​not for everyone, maybe it can be added as an option during installation?