vinceliuice / Sierra-gtk-theme

MacOS High Sierra like theme for GTK 3, GTK 2 and Gnome-Shell etc.
https://vinceliuice.github.io
GNU General Public License v3.0
503 stars 58 forks source link

Check for DESTDIR variable in install script #8

Closed jubalh closed 6 years ago

jubalh commented 6 years ago

In case someone (distribution packager) wants to set the path himself lets check for the DESTDIR variable. If none is set do the same as before and install depending on UID.

vinceliuice commented 6 years ago

Thanks!

vinceliuice commented 6 years ago

But after testing, I found that only root user can run, can not run as an ordinary user

jubalh commented 6 years ago

That should not happen. I tested here too, and it works for root and ordinary user. How did you test it, and on what system? For me it works perfectly.

vinceliuice commented 6 years ago

Show no permissions to rm or cp, I'm not clear where it went wrong

jubalh commented 6 years ago

Show no permissions to rm or cp

Sorry, I don't get what you mean by that. Can you elaborate? :)

vinceliuice commented 6 years ago

2018-04-09 22-54-16

vinceliuice commented 6 years ago

Can not do anything( copy or remove file) with this script when I use my ordinary user

jubalh commented 6 years ago

Did you set DESTDIR in that example?

vinceliuice commented 6 years ago

this is my Install 2018-04-10 20-48-20

jubalh commented 6 years ago

Okay, and you run it just like ./Install or do you set DESTDIR=/some/place ./INSTALL ?

vinceliuice commented 6 years ago

I just open terminal and run ./Install

jubalh commented 6 years ago

Just to be sure, can you do this:

echo $DESTDIR
./Install

and post me the output?

vinceliuice commented 6 years ago

2018-04-10 23-53-18

jubalh commented 6 years ago

Yes, thats how it should be. Even with my change the same thing should happen. Actually I wanted to ask you to run these commands with my change applied :)

vinceliuice commented 6 years ago

This script is just for general users to install, so I think it is more suitable for general users to use this installation script