New framework usage - Githubissues

stormbeforesunsetbee commented 3 years ago

Sorry, I didn't tell you how to use the framework

In that framework, we have:

install.sh, used to install the theme and specialized for multiple customization parameters, e.g. install.sh -t red -t blue
tweaks.sh, used to install and tweaks that requires only a single parameter, e.g. tweaks.sh -g -t red, not tweaks.sh -g -t red -t green. You can only install a single GDM theme, right?
lib-core.sh, is a common lib used by install.sh and tweaks.sh. It's also used to store the common variables. The variables there are specialized for single parameters like tweaks.sh. That's why install.sh overrides its default values to fit multiple customization parameters. E.g: https://github.com/vinceliuice/WhiteSur-gtk-theme/blob/75e32c6314dbb470537982edf0861fa1bac46266/install.sh#L19
lib-install.sh, used to install the theme components and tweaking functions

To add a new feature without a parameter, you just need to add a case in PARSE ARGUMENTS section in install.sh or tweaks.sh, and define your variable in lib-core.sh.

And to add a feature with a parameter, you need to define your variable and/or array variable in lib-core.sh and register it to has_set and need_dialog arrays, and also add a case in the parsimplify function. You also need to register it to check_param function and you can finally add it to the PARSE ARGUMENTS section.

Talking about naming, the value of normal, default, and standard will be converted to a blank string

OOT: Vince, please change this line according to this framework guide: https://github.com/vinceliuice/WhiteSur-gtk-theme/blob/75e32c6314dbb470537982edf0861fa1bac46266/lib-core.sh#L82

And yeah, that's okay if you don't like the new appearence, but please keep it available :) Oh yeah, please use a single parameter like --use-experimental-style instead of adding an option to NAUTILUS_STYLE_VARIANTS. Thank you

vinceliuice commented 3 years ago

No problem! I'll try my best to master this framework usage

stormbeforesunsetbee commented 3 years ago

Vince, if you have any trouble using this framework, please tell me. I know this framework isn't intuitive, that's why I planning to seperate this framework from this repo

vinceliuice commented 3 years ago

I add a gtk-base.scss file for theme variants https://github.com/vinceliuice/WhiteSur-gtk-theme/blob/ff70f27bfb7a8f8d3d208a3965664ecf4425769e/lib-install.sh#L554 But there sometime it will have issues when I run ./install.sh, sometime it will fail to copy _gtk-base.scss to_gtk-base-temp.scss I don't know what's going on

stormbeforesunsetbee commented 3 years ago

I'll help you, insha Allah. But, can you freeze this project for at least 1 week (7 days)? Tell me when you're ready

vinceliuice commented 3 years ago

Thanks, I'm ok now. I'll freeze it since today

vinceliuice / WhiteSur-gtk-theme

New framework usage #171