search

vinceliuice / WhiteSur-gtk-theme

MacOS like theme for all gtk based desktops
MIT License
5.9k stars 607 forks source link

XFCE Notification button very barely readable. #192

Closed ghost closed 3 years ago

ghost commented 3 years ago

On xfce, when i get a notification with a button, the button is barely visible. Especially in normal indoors daylight. This is only the light theme and it affects the latest version. The button can be seen when you hover over it, but it doesn't help if you don't notice that there is a button to begin with. Strangely enough, on the dark theme, the button text color and the notification text color seems to be the same.

Here is an example: light-button-label

It would be greatly appreciated if you can improve the contrast of the button a bit. Maybe by making the text darker? Or making the actual button a bit darker?

Other than that i think you did a fantastic job with this theme! I love it very much!

codic12 commented 3 years ago

Also, when hovering over icons in xfce4-panel, at least in the dark version, it leaves a lingering effect where the item hovered over stays hovered over but dimmed for a while. It feels kinda broken on xfce, it would be great if you could test it. Clock font also seems a bit weird. Panel transparency is definitely broken. Thanks!

codic12 commented 3 years ago

(at least in the dark theme).

codic12 commented 3 years ago

sorry, it seems to be gone after a restart of the xfce4-panel.

stormbeforesunsetbee commented 3 years ago

On xfce, when i get a notification with a button, the button is barely visible. Especially in normal indoors daylight. This is only the light theme and it affects the latest version. The button can be seen when you hover over it, but it doesn't help if you don't notice that there is a button to begin with. Strangely enough, on the dark theme, the button text color and the notification text color seems to be the same.

Here is an example: light-button-label

It would be greatly appreciated if you can improve the contrast of the button a bit. Maybe by making the text darker? Or making the actual button a bit darker?

Other than that i think you did a fantastic job with this theme! I love it very much!

~Hey, your panel looks so opaque!~ Are you using an Arch-based distro?

EDIT: sorry, it's a different issue :v

Are you using an Arch-based distro?

I'm just asking ;)

stormbeforesunsetbee commented 3 years ago

sorry, it seems to be gone after a restart of the xfce4-panel.

Sorry, I ask again. What is your distro?

codic12 commented 3 years ago

Arch linux. I think there was a conflict between the old and new theme.

ghost commented 3 years ago

I am using linux mint 20.

stormbeforesunsetbee commented 3 years ago

@codic12 Is that fixed after a logout or restart?

I think you two have different issues here. @el3ctr0lyte talks about his notification balloon while @codic12 talks about his panel

codic12 commented 3 years ago

Yes, I said my issue was fixed. Yeah, I just hijacked an issue because it had the xfce name on it. Sorry!

stormbeforesunsetbee commented 3 years ago

Yes, I said my issue was fixed. Yeah, I just hijacked an issue because it had the xfce name on it. Sorry!

No worries