search

vinceliuice / WhiteSur-gtk-theme

MacOS like theme for all gtk based desktops
MIT License
5.95k stars 614 forks source link

Nautilus 3.36.3 sidebar looks broken on hover #3

Closed logix2 closed 4 years ago

logix2 commented 4 years ago

Using Nautilus 3.36.3, GTK 3.24.20, GNOME Shell 3.36.3 on Ubuntu 20.04, the Nautilus sidebar looks broken on hover:

Peek 2020-07-15 14-21

Larsklopstra commented 4 years ago

I experience the same

MahdiBaghbani commented 4 years ago

same here, but in general it's an awesome theme!

ListeningGarden commented 4 years ago

Noticed this as well! Seems like any button in the translucent area is susceptible to it.

nemesisq3a commented 4 years ago

Same here, Manjaro 20.0.3

MahdiBaghbani commented 4 years ago

I guess I found the source of problem.

https://github.com/vinceliuice/WhiteSur-gtk-theme/blob/1146811dafa3996bf5271eca55238ef3d0cbbae6/src/sass/gtk/_applications.scss#L114-L118

this linear gradient calculation seems buggy on hovering (maybe the overlay png file mess with length calculation). I made a lot of changes to your theme @vinceliuice, so I don't know if my solution is any good here, hope you can find right way to fix this. (i used image(color) to fix this, although it doesn't separate sidebar from nautilus folder and file section, but top bar can have different color with no problems).

xxSkyy commented 4 years ago

Same problem on dark version

MahdiBaghbani commented 4 years ago

@hetjagani my solution doesn't preserve the separation of sidebar from main area of nautilus. although it fixes this shadow problem for good. sol

kupokunic commented 4 years ago

@hetjagani my solution doesn't preserve the separation of sidebar from main area of nautilus. although it fixes this shadow problem for good. sol

I fixed the issue by editing the source, going to the gtk-3.0 folder and opening up the CSS I wanted to edit. In this case I went to gtk-dark-solid.css. Then I went to row 4827 and set the background-color to be #333333 from transparent.

deepin-screen-recorder_Select area_20200818203527

vinceliuice commented 4 years ago

I update it, now solid version is OK to use!

hetjagani commented 4 years ago

Screenshot from 2020-08-21 10-00-11

Still the problem exist not on the sidebar, but if anything is in the titlebar above the sidebar it has this white box around it on hover. Can anyone please solve this problem?

vinceliuice commented 4 years ago

Are you using solid version?

hetjagani commented 4 years ago

Yes I am.

vinceliuice commented 4 years ago

You can make the windows button on left

hetjagani commented 4 years ago

But then same issue occurs with the window buttons. There is similar white box on hover in window buttons.

vinceliuice commented 4 years ago

I'll fix this

hetjagani commented 4 years ago

Thanks

vinceliuice commented 4 years ago

Fixed windows button issues on solid version

ferhadme commented 3 years ago

This happened me too. But suddenly, I saw that I'm in Nvidia graphics. The problem was to use normal (non solid) whitesur theme with Nvidia graphics. I changed my graphics to integrated one (because I don't use Nvidia unless I play games), and problem was fixed. So If you're using whitesur-gtk-theme, use integrated graphics(Intel or AMD). But if you're staying with Nvidia, make sure you're using solid version of whitesur-theme. If you have gnome-tweaks-tool, go Tweaks -> Appearance, and change Applications and Shell (in case, if you have user themes extension) option from WhiteSur-(dark/light) to WhiteSur-(dark/light)-solid, or vice versa.

NiTTiX commented 3 years ago

Hi all, using Nautilus 3.38.5, GTK 3.24.24, on Debian 11. The Nautilus sidebar still looks broken on hover using the non-solid variant, as logix2 told us at the beginning. I found out, that this weird behavior is gone on Wayland environment but not on X-Server environment with Nvidia card, which I'm using as standard. And I love the non-solid theme. @vinceliuice, can you examine this behavior on an X-server environment?

Have a nice day Timur