search

vinceliuice / WhiteSur-kde

MacOS big sur theme for kde plasma
GNU General Public License v3.0
860 stars 66 forks source link

PWA icons are showing default Browser icon in Task Manager and Application Menu #94

Closed p134c0d3 closed 3 months ago

p134c0d3 commented 3 months ago

Hello! Love the theme, have been using it a long time across various desktops. Works wonderfully on Gnome. I'm now using KDE Plasma (6.0.2) on Garuda Linux, though I've experienced this since Plasma 5.25ish across various distros. Whenever I install a website as a PWA, instead of showing the icon from the PWA's web manifest, it is instead showing the default Brave Browser icon. When I check the .desktop file for each PWA, it's giving them the value of "brave-pwa_app_id-Default", which seems correct, especially since the icons are showing correctly on the Breeze Dark icon themes. I also checked the web-manifests for each of my PWA's, and they're all giving an icon.png to use in them.

Task Manager: image Desktop/Application Menu: image

I switched to Breeze icons to test this, and on that theme, it does indeed show the PWA's web manifest's icons correctly. Task Manager: image Desktop/Application Menu: image

Is there a way to either:

  1. Check if the application is a PWA, at which point it pulls the icon from the Web Manifest?
  2. Add a conditional that if an icon doesn't exist for an application (such as a PWA), to then check for a web manifest and pull the icon from there?

Thank you for the hard work on this. It's a fantastic icon theme!

p134c0d3 commented 3 months ago

Closing as I opened this on the wrong repo.