search

vinceliuice / grub2-themes

Modern Design theme for Grub2
GNU General Public License v3.0
3.59k stars 246 forks source link

Add Icon: submenu #116

Open Sadi58 opened 3 years ago

Sadi58 commented 3 years ago

I prefer using "--class submenu" for "Advanced options..." menu item. I've tested, and it looks fine. I'm attaching a white one in two sizes as well as a screenshot of my slightly customized Vimix grub theme. If you agree, you can add it to assets. GRUB2Menu1 submenu512 submenu

itorgov commented 3 years ago

Hey @Sadi58! How did you add that icon for the submenu? Could you write a short instruction please?

Sadi58 commented 3 years ago

@itorgov (1) I've added several icons like this to "/boot/grub/themes/Vimix/icons" folder, and (2) I've written a script to make several changes in "/boot/grub/grub.cfg" that I execute after each grub update (all these can probably be done by modifying the appropriate scripts in "/etc/grub.d" in order to make these changes more permanent). The command for additional icons is: sudo sed -i -e "s/'UEFI Firmware Settings'/'UEFI Firmware Settings' --class efi/" -e "s/'Advanced options for KDE neon'/'Advanced options\.\.\.' --class submenu/" -e "s/(recovery mode)'/(recovery)' --class recovery/g" "/boot/grub/grub.cfg" Apparently grub looks for an icon with the same name as the class defined for each menu entry, and the file type (extension) should be the same as others and/or supported as seen in "/boot/grub/grub.cfg" (with commands like "insmod jpeg" and/or "insmod png".

johndzxu commented 3 years ago

It would be nice though if there is a default icon for advanced option. On my Ubuntu the menu entries for advanced options and UEFI settings has no icons by default.

arcolinuxz commented 2 years ago

Can I just second this request?

It just looks off if one icon is missing. ArcoLinux-2022-05-18_07-09_1 or this ArcoLinux-2022-05-18_07-12

ps. I like the icon suggested here - it show the hierarchy - could you include this or something similar

arcolinuxz commented 2 years ago

I am not sure we can do anything about it - seems like a grub thing...

Sadi58 commented 2 years ago

It's been more tan 12 months since I opened this issue, and I'm unsubscribing from this now. As I've explained below it's very easy to add an icon for "Advanced options...". All you need to do is to download the (hardly visible) icon immediately below the screenshot at the top (https://user-images.githubusercontent.com/6375934/112475735-30449d00-8d82-11eb-9364-d11307a8ac85.png), rename it as "submenu.png", and then move it to "/boot/grub/themes/Vimix/icons/submenu.png"; or use any other icon you like. The others I've mentioned in my comment dated 2021-05-11 (https://github.com/vinceliuice/grub2-themes/issues/116#issuecomment-838047883 ) are a grub thing, which can be tackled with a user script like that.