Removing a theme breaks configuration

vinceliuice / grub2-themes

Modern Design theme for Grub2

GNU General Public License v3.0

3.41k stars 240 forks source link

Removing a theme breaks configuration #149

Closed The-Plottwist closed 2 years ago

The-Plottwist commented 2 years ago

Hello, recently I wanted to install a new theme and delete the old one by using your script. However, it broke my grub configuration. My understanding is that; by removing, it swaps the current grub configuration with a default one. So I managed to redo my configuration without any issues, nevertheless this can be troublesome for some people.

Cheers. PS: Thanks for this great theme tool by the way. It is a great pleasure to have.

The-Plottwist commented 2 years ago

To suggest a sh friendly solution, I recommend:

Retrieving the active theme with: declare ACTIVE_THEME="$(cat path_to_grub/grub | grep GRUB_THEME | grep -v \#)"
Declaring no theme variable with: declare NO_THEME="GRUB_THEME=\"\"" or declare NO_THEME="#$ACTIVE_THEME"
Swapping to no theme with: sed --in-place='.bak' "s|$ACTIVE_THEME|$NO_THEME|g" path_to_grub

PS: -i option from sed --help: -i[SUFFIX], --in-place[=SUFFIX] edit files in place (makes backup if SUFFIX supplied) (Make sure there is no space between -i and SUFFIX)

The-Plottwist commented 2 years ago

Hey @vinceliuice, I had had provided a solution, in case you have missed.

vinceliuice commented 2 years ago

Could you make a pr for me？

The-Plottwist commented 2 years ago

Yes, I would love that, but I am busy at the moment. Is it okay me to do it next week or so?

vinceliuice commented 2 years ago

That's ok, thanks!

The-Plottwist commented 2 years ago

Hey Vince, don't forget to close fixed issues. (I'm closing this time)